Forestry: Community Edition

Forestry: Community Edition

4k Downloads

[Bug] Missing chance display in Bee Product JEI panel

ccpemily opened this issue ยท 5 comments

commented

image

Currently there is no chance display in bee product recipe like JEIBees, add one should be able clarify different chances of product

There exists chanced tooltip code, but:
image
Since the lambda uses Obj2FloatMap, these two stacks are not the same obj in memory, checking it will always return false:
image

commented

Mapping the original hashmap to a new Object2FloatOpenHashMap<Item> would resolve this problem(Item is strictly singleton), but I do not know if there is a better solution or if my solution have any performance impact on gui rendering

commented

For example, if a bee produces exactly 1 comb at 20% and same 1 comb at 10%, it is legal, but the Item -> Float mapping will confuse

commented

Good catch. I thought it was a JEI issue at first since one of my other mods had the problem, but this is clearly on me.

commented

Good catch. I thought it was a JEI issue at first since one of my other mods had the problem, but this is clearly on me.

Since it has such problem I mentioned above, I think it's not suitable for directly throw a PR to you, maybe require a later discuss on DC

commented

I see what you meant now about products with the same item. I'll have a more robust fix soon