Forestry

Forestry

65M Downloads

[1.12.2] Crash after breaking sakura leaves

object626 opened this issue · 2 comments

commented

Context Environment

Minecraft version: 1.12.2

Forestry version: 5.8.2.387

Minecraft Forge version: 14.23.5.2847

Link to your crash log (if the game crashes):
crash-2021-12-12_11.57.15-client.txt
crash-2021-12-12_11.52.44-client.txt
crash-2021-12-12_12.25.12-client.txt

Installed mods:
Advanced Solar Panels (IC2 addon)
AE2
Biomes O Plenty
Brandons Core
BuildCraft
Catwalks
CodeChickenLib
CoFH
FarFromHome
Forestry
Forgelin
Gravitaional Suit (IC2 addon)
Hwyla
ICBM
IC2-Exp
InventoryTweaks
JEI
Mcjtylib
NEI
NuclearCraft
OpenTerrainGenerator
Railcraft
RedstoneFlux
TeslaCore
ThermalDynamics/Expansion/Foundation
TreeChopper
WailaHarvestability

Expected Behavior

Properly render and place item to the inventory.

Current Behavior

Game crashes after breaking sakura (cherry) tree leafs with Advanced Chainsaw from GraviSuit enchanted with Silk Touch.

After game relaunch unable to open the inventory due to the same crash reason.
As for me item is not rendered properly, but placed in the inventory. While opening the inventory, game tries to load its textures/(other staff idk) and fails again

Reproducible: Always
Steps to Reproduce

  1. Find sakura (cherry) tree
  2. Break a leave with fruits (red dots) with Advanced Chainsaw enchanted with Silk Touch
  3. Feel happy due to crash :-))

After game relaunch.

  1. Open the inventory
  2. Enjoy the crash :-))

Possible Solution and thoughts about bug

Im not familiar with Minecraft modding development but as I can understand from the crash log and Java error message there are error in passing ItemStack as param to Renderer related function and thats cause uncaught IllegalArgumentException.

For now quick fix to make the world playable again ( ability to open the inventory) u should use the following command:
/сlear playerID forestry:leaves.default.fruit.0

The quick fix in code would be probably catching this exception and destroy the item if the render error occurs, but this is only for preventing game crash, not fixing behavior. Also it is a possibility that its impossible to place that kind of catch block due to architecture.

commented

Probably related to #2502 and #2612

commented

Resolved in newer versions.
#2522
#2336