Forestry

Forestry

66M Downloads

Weird Crafting behaviour

JohanniklasLp opened this issue ยท 5 comments

commented

Forestry Version: 1.12.2-5.8.2.424 and .425 (.423 does not have this issue)

Tested in a pack with only Forestry and JEI

TL;DR: For some recipes, the items required for the corresponding machine to start crafting the recipe are different than the ingredients of that recipe.


Some recipes cannot be crafted correctly. As an example, I am going to use Scented Paneling, which have the following recipe in the carpenter:

Image

When putting the recipe and sufficient ingredients into a carpenter, the carpenter says "Inventory needs resources" despite having exactly what should be required:

Image

Scented Paneling is still craftable, but it requires 3 planks and 4 royal jelly:

Image

It consumes the planks and 1 of the 4 royal jelly, as well as 500mB of Honey:

Image

Another example is Orchid Electron Tubes, which need 7 redstone ore, 0 repeaters, and consumes 5 ores:

Image

Image

Image

If the Thermionic Fabricator contains 7 Redstone Ores and 2 Repeaters, it will also still consume the 2 repeaters. Same if you add the other ingredients for the Scented Paneling in the first example. Basically, for some recipes, the requirements for the machine to start crafting the recipe are different than the ingredients of that recipe (this is the part that is not working correctly), but it will still only consume the ingredients of that recipe, if they are in the machine, no other items and not in greater amounts than what the recipe needs (this seems to be correct behaviour).

Not all recipes show this or similar behaviour, Obsidian Electron Tubes for example work.

commented

It seems to still always require the same amount of items total to start, but I get the feeling that it is counting items towards the wrong itemstack. It also kinda feels like this is only affecting recipes that include an Oredict? But I cannot find a pattern of which Oredict recipes work and which don't, the habitat screen for example works fine.
Edit: The Orchid Tube recipe uses ItemStacks, not Oredicts, and the Ender Tube works fine, so that assumption is probably wrong (it was appearently, in fact, the opposite, not oredicts but non-oredicts)

commented

I've had the same issue on scented panels, I assumed it was my server being weird as I had some heavy lags at the time, it didn't even consume 1 pollen cluster for all crafts

commented

The bug is due to this line from the commit to fix carpenter dupes 7ad843. All non-oredict entries will grow the first non-oredict itemstack in the recipe because all non-oredict entries have corresponding dict = "". So in the scented paneling case, as there are 4 non-oredict items and 3 oredict items, the recipe only needs 4 royal jelly (the first non-oredict item) and 3 planks (oredict).

commented

So when will the author fix this problem? I'm also having this issue in my modpack, where players don't have to spend a lot of materials to make the recipe I added.

commented

I will fix it this week, been busy lately.