Server crash if Stack item is null
ultrasn0w opened this issue · 9 comments
Just experienced this crash on my server, I wonder if this is intended or not.
https://gist.github.com/ultrasn0w/7e3cfd73bb602cf5d01a19495878eacf
Using forgeessentials-1.7.10-1.4.4.1164.
Can you try updating to the latest version of forge essentials (1176) and see if you still crash
I have looked at the code and this is intended. If the stack item is null when obtaining the item, it will crash. However, you can put it in safemode to disable such crashes at a potential cost of overall stability.
Can you elaborate on what you were doing to have FE checking the permission of a null item?
@ultrasn0w This is not a bug. It is intended behavior of forge essentials. See
Also, can you please give me more information on how this came up. While the crash itself is not a bug, the method it occurred may be.
I am closing this issue for now.
The Issue occured in conjunction with The Twilight Forest mod, using the Lamp of Cinders to pass the Thorn blocks. They're destroyed on touch then and sometimes they apparently drop a null item.
http://ftb.gamepedia.com/Twilight_Forest_Progression#Troll
If this is intended by FE I should contact the TF dev then.
I am not sure why it is intended, you would have to ask @olee, but TF is mentioned in the error message so it is probably something related to TF issues. The way to prevent the crash is to enable safemode.
This is because TF has just never cared to fix that bug they produce.
Dropping a null item stack is just invalid and that's why FE by default will throw an error in this case as well (or such bugs would go unnoticed forever).
However because no one at TF seems to care to fix this, I added that safe-mode flag so at least FE users can prevent the crashes.
TL;DR: Blame TF - I reported this to them once already but nothing happened.
You may send pull requests to their repo, I guess.
https://github.com/Benimatic/twilightforest
Looks like he is finally fixing it.... Slowly
Benimatic/twilightforest@ff5f7f5