ForgeEssentials

ForgeEssentials

339k Downloads

Having FE installed, makes ProjectE Items loose their EMC Value

steelshot opened this issue ยท 10 comments

commented

AS title says it all ProjectE items loose their EMC value when FE is installed, removed it, everything works fine, when i put FE back = no EMC.

MC Vanilla and Modded items that have an EMC value work fine, tho Philosphers stone is the only item that has a EMC value from ProjectE.

I have made an issue on ProjectE's github aswell in case it on their end.

I am using latest Forge, ProjectE, FE build 1166, Latest Forge Server and I am not using KCauldron.

commented

So, does Forge essentials do something weird to the crafting recipe list or something like that?

commented

I dont know, i have not changed anything that would be to do with recipes

commented

Well - the only thing FE does in regards to crafting is this Mixin
https://github.com/ForgeEssentials/ForgeEssentials/blob/300aa28473a06125ff2089ef9ffeaff9c693ce78/src/main/java/com/forgeessentials/core/preloader/mixin/item/crafting/MixinCraftingManager.java

It might be that ProjectE uses this function as well with player set to null which would make the function not return anything. I quickly patched it to check for that condition and you might want to try again with the latest version now.

commented

No, i don't think we use this method. Weird thing. Will try to take a deeper look at this later. Thanks for investigating.

commented

Still does not work, latest FE, with newly fresh permissions and settings regenerated in a fresh world, tho with all of my mods
gonna test just FE with PE and report straight away back here

EDIT:1 FE seems to work fine with PE, EMC values are being shown, tracking other mods now that would mb interact.

commented

That's good to know.

commented

Strange thing tho, removing FE from the main server, fixed the issues, but running just those 2 it works....

P.S. Thats my mods that i use, maybe some of these are know to cause isssues or such
http://pastebin.com/NNwUiLuQ
server log: https://gist.githubusercontent.com/SteelShot/5edd1fe1acd96d728cc742f926ba5e18/raw/2627e08cfedde101bba28476cfd2de6e635775e2/Log

commented

Report again after testing with the latest build and maybe it works.
If not we will have to try something else.

commented

See the reference. JustEnoughCalculation was narrowed down.

commented

It is confirmed to be caused by me. I used an itemStack with null item as ingredient in the recipe and force to insert the itemStack using reflection.
Here is the code I used: https://gist.github.com/Towdium/42f3cc97e4644af0eef8ff759933e5dd
Not sure why FE can have some effect on this issue since it seems totally my fault.