Forgero - [Fabric]

Forgero - [Fabric]

85k Downloads

Conditions do not appear to apply to parts made from schematics and vice versa

UnusedCactus opened this issue ยท 5 comments

commented

When attempting to make a part from the necessary materials and a schematic with conditions, the conditions do not appear to be applied to the resulting item.
image
image
This also applies to schematics made from parts, either made using the assembly station, or crafting by hand. This may be a feature, so ignore this if it is.
image
image
(^the resulting schematic)
image
image
This isn't like the issue where the REI crafting recipe menu shows the incorrect result (that might not be able to be fixed... not a deal breaker anyways), as it occurs without fail in regular crafting tables and the assembly station.

commented

Hey! Thanks for the issue, I should probably make it a bit more clear exactly how conditions apply. Don't worry, I haven't really made this clear anywhere so it's quite natural to assume this is an issue.

Conditions are not supposed to be able to carry over when going from part -> schematic. The process for creating schematics is also going to undergo a rework at some point in the nearish future, so the implementation is currently quite simple.

The attributes of the condition will carry over when used to craft parts. If you compare the lightweight pickaxe head you created with one crafted with another schematic, you should see the that the attributes are actually different. The condition names stay on the part that they originated from. If this is not the case, and they have the exact same stats, even though one was created from a schematic with conditions, then it is bugged. So it would be nice of you could double check that ๐Ÿ‘

commented

image
image
image
The stats do change, however the change is not really obvious. Using 3 different Lightweight Pickaxe Head schematics (the last one is normal) there is definitely a change in stats. I just couldn't really tell I guess.

commented

That's a good point. The mod has some issues with displaying how stats differ when upgraded. There have been a suggestion to colorize the attributes based on how they compare to the default one. Do you think this would make it easier to see that the part has indeed been affected by the condition of the schematic?

commented

An example of this would be that the stat that has changed would turn more green if it's better and more red if it's getting worse.

commented

In hindsight, it would make a lot more sense if the names of the conditions also applied to the parts that was crafted with a conditioned schematic.