Forgero - [Fabric]

Forgero - [Fabric]

85k Downloads

Fps dropping from 600-700~ to 10-20~ when having tools in a hotbar

georg22890 opened this issue ยท 7 comments

commented

2023-09-14_10 56 48
2023-09-14_10 56 55

Minecraft 1.20.1

Mods = REI 12.0.645 , Sodium 0.5.2, Forgero 0.11.1

commented

Played on 0.10.9.4 version of forgero, there was no issue with fps. Now there is

commented

And as for me, it would be fun to have custom armor in this mod

We are working towards this in the long run, but it's still going to take a while until that will be worked on!

commented

Thanks for the issue! That is really bad.

I believe this is caused by the recent reword to the model predicates, which introduces new conditions for selecting appropriate models. This is likely causing cache invalidations, which makes forgero try to recreate the entire tool model every single frame.

I think this might be solved by extending the cache lifecycle, and marking certain predicates as dynamic. This way we can better sort through only the actual dynamic model templates, and not all available models for every tool each frame.

It will likely require some restructuring in the model renderer, but I think it will solve the issue. I will try to get this done as fast as possible and release it as 0.11.2๐Ÿ‘

commented

Thanks!

commented

Also, nice tools ๐Ÿ”ฅ

commented

And as for me, it would be fun to have custom armor in this mod

commented

I created a quick patch for this issue which resolves the most prominent issue due to using uncachable objects for storing the created models. This will also require bigger rework in the future to properly handle model predicates that depend on world state, but that will have to wait for a while, as this issue is to big to be put on wait.

Fps should return to normal when using this patch, but models that depend on world state might be a little inconsistent. I will release this patch as 0.11.2 ๐Ÿ‘