inanimates_can_be_invisible doesn't work correctly with glow frames
SplendidAlakey opened this issue · 6 comments
MC 1.19.2
Fabric loader 0.14.17 ] API 0.75.1
Improved Signs 1.2.0
Fabrication 3.2.0
To reproduce:
- Install both mods and run the game with default configs
- Create/load into a world, place a glow item frame anywhere you want
- Place any item into the frame
- Make the item frame invisible with the amethyst shard
- Hit the frame to make it visible again
- Receive no shard back, which is the intended behaviour of Improved Signs
Disabling/unsetting inanimates_can_be_invisible restores the intended behaviour.
Logs: https://gist.github.com/SplendidAlakey/b305d639c04b4604110a17f80fa61866
Improved Signs on its own does not return Amethyst Shards when un-invisible-ing item frames — I checked the code and tested in a fresh instance. The modpack you experienced the drop behavior in probably has Charm, which is duplicating amethyst shards when frames are made invisible by other mods. In this case it's not a dupe as the other mod is also using an amethyst shard. See https://github.com/svenhjol/Charm/issues/639 — we have a workaround on our side ("Fix Charm Amethyst Dupe" feature) but Charm has not (and likely never will) fix the underlying issue.
Sorry, the shard does indeed not return with just Improved Signs.
However, there's still a bug between Fabrication and Improved Signs: the item itself in the glow frame becomes invisible, when you make the frame invisible. I completely forgot to mention this in the initial report... Should I make a new one?
Quick edit:
Unless that's what the rule should do and I completely misunderstood it, however, then the bug is the opposite - the regular frame doesn't get affected.
With the rule enabled:
Without the rule:
It's only "modded" in a sense, that the invisibility feature is added by a mod, the frame itself is vanilla glow item frame. Just to be clear.
fixed in the next release ( 06317b0 )