Forgery

Forgery

823k Downloads

Bug & Feature request

BioTechproject27 opened this issue · 3 comments

commented

Server Only

When adding enchants that would normally not be
compatible it will instead get added in an inactive state.
Conflicting enchants can be swapped on the go by right-clicking the
item or pressing a keybind while sneaking.

Demonstration video: https://unascribed.com/fabrication/swap_conflicting_enchants.mp4
extra.swap_conflicting_enchants=

Bug:
-Enchantments always swap when sneak-using, even if other keybind is set.
-Also enchantments can't "be swapped on the go by right-clicking the item." Or perhaps this is a misinterpretation and it's supposed to be read like: "Conflicting enchants can be swapped on the go by right-clicking the item while sneaking or pressing a keybind while sneaking."

In which case this is a feature request to make sneak-using be replaced by the keybind.
Also being able to see the other enchantments when e.g. having advanced tooltips enabled would be cool.

commented

Added a dark gray tooltip.
Swap conflicing enchants is now scriptable which means it's available in taggable players and can also be configured to a fair degree. for example you can make it work on just rightclick/keybind or require the player to shift and be wet, up to you.

commented

Nice, where can I find documentation on how to do so?

commented

for the scripting part fscript needs to be installed.
then a button shows up to toggle only scriptable features and you can just click on them.

(also fscript isn't really made to have no conditions out of the box so for now you can just do something silly like (sneaky; !sneaky), in case you wish to use a script and taggable players simultaniously there's a taggable players codition added by fabrication)

out.mp4