Game does not launch with Create: Destroy addon on the latest version.
water-mizuu opened this issue · 3 comments
Describe the bug
The log describes a mixin failure with fabric-item-api apparently, which only appeared in the latest version of the API.
Steps to reproduce
- Install Connector and its family of mods
- Install Create 0.5.1f and the Destroy addon 0.8
Logs
https://gist.github.com/water-mizuu/e08dec8271b03940abafca2c3547e584
Additional context
This did not happen before the latest update.
The problem stems from Destroy completely @Overwriteing ClientPlayerInteractionManager#isCurrentlyBreaking / MultiPlayerGameMode#sameDestroyTarget:
https://github.com/petrolpark/Destroy/blob/7d91768bf5d55c2ba399115269ef877f9cf76144/src/main/java/com/petrolpark/destroy/mixin/MultiPlayerGameModeMixin.java#L16-L26
Apparently, Destroy has this workaround because Forge's own implementation of FabricItem#allowContinuingBlockBreaking (that being IForgeItem#shouldCauseBlockBreakReset) doesn't actually work? (Petrolpark-Mods/Destroy#37, neoforged/NeoForge#143)
That oversight was, however, fixed in NeoForge: neoforged/NeoForge#145