Forgotten Graves

Forgotten Graves

273k Downloads

Compatibility with Accessories

A5ho9999 opened this issue · 3 comments

commented

Is your feature request related to a problem? Please describe.
Doesn't appear to save equipped Accessories/Trinkets on death

Describe the feature you would like to see.
Compatibility like that of trinkets, I've only tested this with the 1.20.1 version as that's the current modpack in testing.

Additional context
Mod: https://modrinth.com/mod/accessories

When testing this in the modpack I get

[10:28:20] [Render thread/INFO]: [System] [CHAT] A5ho9999 fell from a high place
[10:28:20] [Render thread/INFO]: [System] [CHAT] [G] Grave spawned at -5028x 67y 1094z.
[10:28:20] [Render thread/ERROR]: Unable to Sync Container Data for a given Entity as it is null on the Client! [EntityId: 72]

but when just testing with the graves and accessories no errors are logged but the slots/equipped items still aren't saved.

commented

Hey, thanks for the report! I can definitely look into adding support for Accessories at some point. I can't promise a specific timeline, though.

I've done some basic playing around with the two mods and accessories-tc-layer. It seems like the items will simply drop if the compatibility layer isn't installed.. but if it is, any items in the cosmetic slots will be restored properly while any item in the regular slots will be destroyed.

I might be able to whip something up to at least prevent the items from outright being destroyed while the compatibility layer is installed.

EDIT: It seems like I've managed to prevent the items from outright being deleted, at least; this functionality will be pushed out in v3.2.17. When you retrieve your grave, the item that failed to equip will either end up in your vanilla inventory or be dropped on the floor (if the vanilla inventory is full).

commented

Alright, v3.2.17 has been released. If you run into any issues with the compatibility layer installed and with items being deleted please let me know (especially which items are being deleted and from what mod). If the compatibility layer isn't installed the items should simply drop on the ground, so vanilla rules will apply there (they'll despawn, etc).

I'll try and look into adding dedicated support at some point, but it might be weird since I'll have to consider the compatibility layer(s) as well as the main mod. Thanks again for the report!

commented

Thanks for the quick work, seems like it's fixed but will double check once the server has also been updated (and for someone to die naturally).