[BUG] Items still dropping on the ground
Typhewn opened this issue · 10 comments
Describe the bug
The items in curious and possibly accessories/trinkets drop on the floor still may we please get a way to either keep these on the player or have them stay in the grave (Possibly both) within the config?
Forgotten Graves Version
3.2.18
To Reproduce
A list of steps to reproduce your issue, i.e.:
- literally just die with the item in a slot using synatra connector to make the mods compatible of course but once you die using curios it will guaranteed drop if the item is in one of the mods slots.
Expected behavior
Stay in the grave.
Hmm, that's intended behavior as of right now -- any modded inventories that my mod isn't aware of/doesn't support will just drop (there was a time where they were just deleted 😬). But I may be able to make it so that the items just stay on your character rather than dropping, and could definitely make it a config option if what I'm thinking will work does actually work. I have to do some testing first and I'll let you know. 🤔
Ok nice and it hopefully should work also I use synatra connector so fingers crossed lol
I've played around with the code a bit and I seem to have something that's working (at least on Fabric). The items stay on the player (as opposed to dropping).
Not really sure if I want to make a configuration option for it or just tie it into the keepInventory gamerule. Either way, I should be able to release it in a day or two.
What version of Minecraft are you on? I can upload a jar on here for you to test to see if it works using Sinytra Connector or not. I'm working on trying to resolve #115 before I release the update (but if I can't fix that today, I'll release the version that should fix this issue tomorrow).
No worries! I'm releasing version 3.2.19 now which should let you change the behavior via keepInventory. Can you test it and let me know if it works well for you?
To allow for items in unsupported inventories to stay on your player (rather than be dropped), but all other items be put into the grave, your settings should look like this:
- Minecraft's
keepInventorygamerule should betrue. - Forgotten Graves'
respectKeepInventoryconfiguration option should be set tofalse.
I'll look into adding actual support for Accessories at some point (#111 requested it too).
But it seems like the only supported Fabric version is 1.16.5 for Curios, so I'm not entirely sure how to go about adding support for it just yet (with it more or less being a Forge-specific mod).