Forgotten Graves

Forgotten Graves

273k Downloads

[FEATURE] About compatibility with keep inventory

Zt192 opened this issue · 8 comments

commented

Hi, recently a similar compatibility feature was removed, but I still haven't found its analogues or anything similar in the mod :(.

I'd like to see it again, or something similar, as it's useful for modpacks.

Adding an old or new version of this function.

commented

Hmm, so the reason I removed respectKeepInventory is because setting it to true while having keep inventory on is the same as setting graves to false while having keep inventory on.

But having keep inventory on should still work as it used to -- any items in supported inventories (Trinkets, Inventorio, BackSlot, Vanilla) should go into the grave while any items in unsupported inventories should stay on the player (due to keep inventory).

Can you explain what you were using it for and how it benefited you? Or the issue you're running into now? 🤔 I'm definitely not against re-adding it if there's an use-case I missed.

commented

Hi, I'm currently working on a modpack, many players would use it to replace graves, for their convenience.

commented

Hmm, you could add graves to the clientOptions list, like this:

{
  "main": {
    "graves": true,
    "disableInPvP": false,
    "graveCoordinates": true,
    "retrievalType": "BOTH",
    "mergeOrder": "GRAVE",
    "dropType": "EQUIP",
    "sneakSwapsDropType": true
  },
  "experience": {
    "expStorageType": "ALL",
    "percentage": 100,
    "percentageType": "POINTS",
    "cap": -1,
    "capType": "LEVELS"
  },
  "spawning": {
    "sinkInAir": true,
    "sinkInWater": true,
    "sinkInLava": false,
    "sinkThroughBlocks": true,
    "replaceBlocks": true,
    "giveDeathCompass": false
  },
  "decay": {
    "decayEnabled": true,
    "decayModifier": 50,
    "decayBreaksItems": false,
    "decayRobbing": "FRESH",
    "freshGraveDecayChance": 5,
    "oldGraveDecayChance": 12,
    "weatheredGraveDecayChance": 16,
    "minStageTimeSeconds": 30,
    "maxStageTimeSeconds": 300
  },
  "server": {
    "graveRobbing": false,
    "storedGravesAmount": 15,
    "destructiveDeleteCommand": false,
    "OPOverrideLevel": 4,
    "clientOptions": [
      "graves"
    ]
  }
}

That would allow the players to decide whether they want to use the graves or not. Would that work? 🤔

commented

This was an accidental closure, sorry.

I put it in the config, and didn't really understand how it worked, because it didn't help with the keep inventory.

The old function was useful because it only worked with this rule.

That is, the player only needed to enable the rule and not have to go into the config to disable graves. So it was convenient for everyone, those who want to play with graves and those who just keep inventory.

commented

The disable graves feature just disables the mod, and the old feature added compatibility specifically with keep inventory enabled. I hope you understand me, I like your mod very much, the best mod on graves, and this function is very much missing.

commented

No worries about the accidental closure! Hmm, so you have something that allows per-player gamerules and it was useful since it only applied to people with keep inventory enabled? I can add it back, it definitely doesn't hurt to have it, but I might change the name of it so it's less vague than respectKeepInventory... maybe something like keepInventoryDisablesGraves? I'll add it back in the next update.

commented

Ok, I'll close the ticket then, thanks for such quick and kind support ❤️

commented

Alright, I released v3.2.25 which has this again, enjoy!