Forgotten Graves

Forgotten Graves

273k Downloads

[FEATURE] Update to 1.18

ginsm opened this issue ยท 2 comments

commented

Describe the solution you'd like
As the title says, begin work on updating to 1.18.

This will be the next thing that's worked on.

commented

Apparently serialization and client syncing has changed quite a bit for block entities, and as a result they removed BlockEntityClientSerializable from Fabric API:

https://bit.ly/3d1GLSy

There's a few things I'll need to do to get it up and running again:

  1. Remove anything related to BlockEntityClientSerializable.class.
  2. Create a .sync helper method on GraveBlockEntity.
  3. Implement client syncing using the new methods found on BlockEntity.class (toUpdatePacket and toInitialChunkDataNbt.
  4. Revise writeNbt and readNbt a little.

According to the issue, I can leverage BlockEntityUpdateS2CPacket.create alongside toUpdatePacket to easily generate an update packet for the client.

commented

Commit e123d49 resolves this.

Ported from 1.17.1 to 1.18 (Caves & Cliffs: Part II)

In the process I updated the mod to use Java 17 & the most recent fabric loader (1.12.8).
Make sure you update as well! :)

Closing.