Forgotten Graves

Forgotten Graves

Mods
273k Downloads

[BUG] getting killed by creepers (and possibly explosions but i haven't tested this) will prevent graves spawning.

jabthetab opened this issue · 8 comments

commented

Describe the bug
title is self-explanatory. i expect that it's from the grave spawning before the explosion happens and then getting destroyed or something.

Forgotten Graves Version
1.19.4 - 3.0.4

To Reproduce
A list of steps to reproduce your issue, i.e.:

  1. die to a creeper with items in your inventory.
  2. walk back to your place of death.
  3. discover an empty crater without a grave in it and mourn your items.

Expected behavior
to not permanently lose my items. every time i die to a creeper.

Additional context
[none]

Screenshots
image

commented

Thanks for the report and humorous screenshot. That's definitely not supposed to happen!

Graves have a blast resistance of 3600000.. the same as Bedrock. Definitely not supposed to explode; and they don't even explode if they were placed prior to the explosion. But, here we are, exploding graves!

Either way! I do have a fix I'm testing currently and I'll be pushing it to the affected versions soon (I'll start with v1.19.4, expect it in like ~20 mins or so).

commented

Okay, 1.19.4-v3.0.5 is up on CurseForge and Modrinth now and should fix this. Let me know if there's any further issues, and thanks again for the report! 😁

commented

Hey, i don't know it was before patch, but now it looks like graves spawn after dying from creeper but the grave is empty. I mean it is just a block that you can craft.
image

commented

That's strange. When I test it, it spawns the grave properly:

image

Which version are you using? And what other mods are you using? 🤔 Any logs you could share?

commented

Never mind, it is actually incompatibility between my mod called better explosions. I am sure i can fix it on my side just by excluding graves from interacting with it. But i am curious when this mod creates the grave? Could you send code snippet?

commented

Got it working (really badly but works, i need to figure out how to save block entities and their inventories). Thanks tho!

commented

Yeah, I don't think there's an easy way to do it for all mods/block entities.. but if you want help doing so with my particular mod, I'm free tomorrow, just shoot me a message on Discord (Syh#9864).

Either way, I'm going to re-close this issue. :P