[Crash] New placement feature isn't improved
A5ho9999 opened this issue · 4 comments
Describe the bug
The new placement is replacing blocks and crashing when can't be placed (wasn't an issue until new placement)
Full Log: https://gist.github.com/A5ho9999/4aaa1f160f484b1f2ca1275bbd78bd12
Forgotten Graves Version
Forgotten Graves 1.20.1-3.2.3
To Reproduce
- Go to end
- Jump into void
- Crash
Expected behavior
Not replace blocks and just place in air + not crashing the game
Additional context
at net.minecraft.class_1937.method_8320(class_1937.java:16551)
at me.mgin.graves.block.utility.PlaceGrave.spawnGrave(PlaceGrave.java:217)
at me.mgin.graves.block.utility.PlaceGrave.place(PlaceGrave.java:62)
at net.minecraft.class_1657.redirect$gci000$forgottengraves$dropAll(class_1657.java:18900)
at net.minecraft.class_1657.method_16078(class_1657.java:683)
at net.minecraft.class_1309.method_16080(class_1309.java:1413)
at net.minecraft.class_3222.method_6078(class_3222.java:643)
at net.minecraft.class_1309.method_5643(class_1309.java:1222)
at net.minecraft.class_1657.method_5643(class_1657.java:928)
at net.minecraft.class_3222.method_5643(class_3222.java:732)
at net.minecraft.class_1309.method_5825(class_1309.java:1876)
at net.minecraft.class_1297.method_31473(class_1297.java:553)
at net.minecraft.class_1297.method_5670(class_1297.java:536)
at net.minecraft.class_1309.method_5670(class_1309.java:367)
at net.minecraft.class_1297.method_5773(class_1297.java:474)
at net.minecraft.class_1309.method_5773(class_1309.java:2380)
at net.minecraft.class_1657.method_5773(class_1657.java:283)
at net.minecraft.class_3222.method_14226(class_3222.java:510)
at net.minecraft.class_3244.mixinextras$bridge$method_14226$273(class_3244.java)
at com.bawnorton.neruina.handler.NeruinaTickHandler.safelyTickPlayer$notTheCauseOfTickLag(NeruinaTickHandler.java:59)
at net.minecraft.class_3244.wrapOperation$iel000$neruina$catchTickingPlayer(class_3244.java:9955)
at net.minecraft.class_3244.method_18784(class_3244.java:269)
at net.minecraft.class_2535.method_10754(class_2535.java:259)
at net.minecraft.class_3242.method_14357(class_3242.java:172)
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:908)
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:824)
at net.minecraft.class_1132.method_3748(class_1132.java:105)
Screenshots
Replaced block on ground instead of placing on block
Thanks for the report! I'm publishing v3.2.4 to Modrinth and CurseForge now which should fix the crash.
Are you able to reproduce it replacing blocks? 🤔 If so, what steps were you taking? I've been unable to reproduce it in my testing, even when it comes to things like half slabs, path blocks, soul sand, torches, fences, etc.
Either way, I'll take a look at the code some more after work today and see if I can't improve it a bit more.
Yup, if you have a platform (with nothing under it) and torches on top, dying on it with something like a torch. it replaces the block under
