Crash when loading mod in development environment with Mojmap
BluSpring opened this issue ยท 8 comments
Minecraft version information
1.20.1
Mod loader information
Fabric
Mod loader version information
0.16.9 (Fabric)
Mod version information
3.0.6
Reproduction Steps
- Create a mod development environment with Mojang mappings
- Add mod to development environment (either by directly adding the mod into the
run/modsfolder, or by adding it as a dependency in Gradle) - Launch the game
Crash Report and latest.log
No crash report was generated, due to this being a direct crash in Fabric Loader itself.
[01:53:26] [main/WARN] (FabricLoader/Knot) Class path entries reference missing files: K:\BluSpringStudios\Dev\Minecraft\Tests\FFCrashRepro\build\classes\java\main - the game may not load properly!
[01:53:26] [main/INFO] (FabricLoader/GameProvider) Loading Minecraft 1.20.1 with Fabric Loader 0.16.9
[01:53:26] [main/INFO] (FabricLoader) Loading 62 mods:
- fabric-api 0.92.3+1.20.1
- fabric-api-base 0.4.31+1802ada577
- fabric-api-lookup-api-v1 1.6.36+1802ada577
- fabric-biome-api-v1 13.0.13+1802ada577
- fabric-block-api-v1 1.0.11+1802ada577
- fabric-block-view-api-v2 1.0.1+1802ada577
- fabric-blockrenderlayer-v1 1.1.41+1802ada577
- fabric-client-tags-api-v1 1.1.2+1802ada577
- fabric-command-api-v1 1.2.34+f71b366f77
- fabric-command-api-v2 2.2.13+1802ada577
- fabric-commands-v0 0.2.51+df3654b377
- fabric-containers-v0 0.1.65+df3654b377
- fabric-content-registries-v0 4.0.12+1802ada577
- fabric-convention-tags-v1 1.5.5+1802ada577
- fabric-crash-report-info-v1 0.2.19+1802ada577
- fabric-data-attachment-api-v1 1.0.1+de0fd6d177
- fabric-data-generation-api-v1 12.3.5+1802ada577
- fabric-dimensions-v1 2.1.54+1802ada577
- fabric-entity-events-v1 1.6.0+1c78457f77
- fabric-events-interaction-v0 0.6.3+13a40c6677
- fabric-events-lifecycle-v0 0.2.63+df3654b377
- fabric-game-rule-api-v1 1.0.40+1802ada577
- fabric-gametest-api-v1 1.2.14+1802ada577
- fabric-item-api-v1 2.1.28+1802ada577
- fabric-item-group-api-v1 4.0.13+1802ada577
- fabric-key-binding-api-v1 1.0.37+1802ada577
- fabric-keybindings-v0 0.2.35+df3654b377
- fabric-language-kotlin 1.13.0+kotlin.2.1.0
- fabric-lifecycle-events-v1 2.2.22+1802ada577
- fabric-loot-api-v2 1.2.2+1802ada577
- fabric-loot-tables-v1 1.1.46+9e7660c677
- fabric-message-api-v1 5.1.9+1802ada577
- fabric-mining-level-api-v1 2.1.51+1802ada577
- fabric-model-loading-api-v1 1.0.3+1802ada577
- fabric-models-v0 0.4.2+9386d8a777
- fabric-networking-api-v1 1.3.12+13a40c6677
- fabric-networking-v0 0.3.52+df3654b377
- fabric-object-builder-api-v1 11.1.4+1802ada577
- fabric-particles-v1 1.1.2+1802ada577
- fabric-recipe-api-v1 1.0.22+1802ada577
- fabric-registry-sync-v0 2.3.4+1802ada577
- fabric-renderer-api-v1 3.2.1+1802ada577
- fabric-renderer-indigo 1.5.2+85287f9f77
- fabric-renderer-registries-v1 3.2.46+df3654b377
- fabric-rendering-data-attachment-v1 0.3.37+92a0d36777
- fabric-rendering-fluids-v1 3.0.28+1802ada577
- fabric-rendering-v0 1.1.49+df3654b377
- fabric-rendering-v1 3.0.8+1802ada577
- fabric-resource-conditions-api-v1 2.3.8+1802ada577
- fabric-resource-loader-v0 0.11.11+fb82e9d777
- fabric-screen-api-v1 2.0.8+1802ada577
- fabric-screen-handler-api-v1 1.3.31+1802ada577
- fabric-sound-api-v1 1.0.13+1802ada577
- fabric-transfer-api-v1 3.3.5+8dd72ea377
- fabric-transitive-access-wideners-v1 4.3.1+1802ada577
- fabricloader 0.16.9
- ffcrashrepro 1.0.0
- friendsandfoes 3.0.6
\-- reach-entity-attributes 2.4.0
- java 17
- minecraft 1.20.1
- mixinextras 0.4.1
[01:53:28] [main/ERROR] (FabricLoader) Failed to remap mods!
net.fabricmc.loader.impl.FormattedException: java.lang.RuntimeException: Unfixable conflicts
at net.fabricmc.loader.impl.discovery.RuntimeModRemapper.remap(RuntimeModRemapper.java:214) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.FabricLoaderImpl.setup(FabricLoaderImpl.java:244) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:193) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:146) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.devlaunchinjector.Main.main(Main.java:86) ~[?:?]
Caused by: java.lang.RuntimeException: Unfixable conflicts
at net.fabricmc.loader.impl.lib.tinyremapper.TinyRemapper.handleConflicts(TinyRemapper.java:898) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.lib.tinyremapper.TinyRemapper.propagate(TinyRemapper.java:798) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.lib.tinyremapper.TinyRemapper.mrjRefresh(TinyRemapper.java:1077) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.lib.tinyremapper.TinyRemapper.apply(TinyRemapper.java:929) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.discovery.RuntimeModRemapper.remap(RuntimeModRemapper.java:167) ~[fabric-loader-0.16.9.jar:?]
... 6 more
Additional information
Upon further inspection, this error was directly caused by 68a2031, more specifically due to the requiredFeatures method.
You should include the mod via build.gradle, so it can remap correctly to your env, placing the file in run/mods is not a great solution, exactly for this reason/issue.
How are you including the mod?
Also I am not sure, what would the fix be on my side, with the mentioned file
You can see it directly in the screenshot - using the artifact from the Modrinth maven under the modRuntimeOnly configuration.
The fix would theoretically be getting rid of the requiredFeatures method in DispenserAddedSpawnEgg.java, but I'm not entirely sure why that was added in the first place, considering getRequiredFeatures already exists and is the method that gets remapped under Yarn, whereas requiredFeatures just seems to simply exist there.
Looking at it in later versions, the requiredFeatures method doesn't even exist there, only getRequiredFeatures - this seems to be specific to 1.20.1 alone.
Yeah, i can try to look into this later, if that's the case, this will probably be one of the last thing for 1.20.x, since i already dropped the support for that version.
you should be able to fix this yourself in your dev environment by adding custom remappings for the vanilla method. I've had this issue (in reverse, using yarn dev and bringing in mojmap dependencies).
https://github.com/TheDeathlyCow/thermoo-patches/tree/1.21.1/mappings