
Race condition with async world saves
lennyservant opened this issue ยท 4 comments
starting a backup w/ Fast Async World Save sometimes results in a failed backup with NoSuchFileException
on world save, Fast Async World Save creates temporary copies of files in world/data
which are then prefixed with tmp_
and are quickly removed
starting a backup triggers a world save, triggering the creation of these temporary files; sometimes these temporary files get included in the scan, which then results in a NoSuchFileException
later as these temp files are already removed
logs: https://mclo.gs/yOYa1vJ
note: i've tried to exclude these temporary files by adding an entry to excluded
in ftbbackups2.json
, but either i've made a mistake or it doesn't work
"excluded": [
"world/data/tmp_*"
],
Your exclude config should work in theory, but it looks like the file deletion is resulting in an error being thrown before we actually get to the stage of checking the exclusion list.
Backups are supposed to only be created after the save is complete, and while no files are being modified.
So the changes made by Fast Async World Save kinda throw a wrench into the works.
I have made some adjustments that may resolve the issue and allow your exclude to work.
Would you mind testing if this fixes the issue?
ftbbackups2-neoforge-1.21-9999.jar