Fun Ores

Fun Ores

Mods
528k Downloads

[Bug] Fish ore drop nothing

drakray opened this issue · 4 comments

commented

Versions

Minecraft Version: 1.12.2
Fun Ores Version: 1.6.2-123
Silent Lib Version: 3.0.0-144

Expected behavior

  • Fish ore to Drop fishy stuff

Actual behaviour

  • Fish ore drop nothing

Steps to reproduce the problem

  1. Have FunOre, Aquaculture, HarvestCraft, Gravestone Extended, and more
  2. Find Fish Ore and Mine it
  3. ...
  4. Nothing Happen

At first I thought it could only be a bad luck, but I just mined a >10 block vein of fish ore with 0 drop :/

Could it be caused by a recent update from FunOre or SilentLib, or simply because I have WAY too many mods that add fishy stuff? I know Aquaculture and Gravestone must be fished with their own fishing rod, but still.
Cam't remember last time it worked though, lately I avoided mining fish ore because I lacked the storage space XD

commented

I was able to reproduce this with only FunOres-1.12.2-1.6.2-123.jar and SilentLib-1.12.2-3.0.8-158.jar in the mods folder, and Forge build 2768 (config modified and custom superflat world to find the ores faster, and creative mode to give myself a diamond pickaxe, but then I switched to survival before mining).

Edit: I found why this is happening!
86334a2#diff-1ebc7cb19fba960d411ad0e101bf95dcR52 added an early return if the EntityLiving for the ore type is null, but fish ore (presumably intentionally) returns such a null here: https://github.com/SilentChaos512/FunOres/blob/1.12/src/main/java/net/silentchaos512/funores/lib/EnumMeat.java#L109

commented
commented

Don't know if it can be related, but I can't use BaseMetal's not Thermal Foundation's Fishing Rod.
I can use Minecraft's, Aquaculture's and Gravestone-Ext's, though

commented

Just so you know, Gravestone-Extended no longer have a fishing module; it's been moved to Advance Fishing, but problem still exist.