Functional Storage

Functional Storage

24M Downloads

[1.19.2] Drawer Visual Item Render Issue

Mitchell5200 opened this issue ยท 12 comments

commented

Modpack: atm8 v1.0.3
Functional storage 1.19.2-1.0.7

The items fail to fully render on forge 43.1.57, but do on forge 43.1.55, pictured below are framed compacting drawers but it affects all FS drawers, and yes, Rubudium is installed in the pack, i do not have any shaders running at this time however

Forge 43.1.57
2022-11-24_13 02 12

Forge 43.1.55
2022-11-25_13 44 15

commented

AS I am having the same issue, I downgraded Forge to 43.1.55 but I am still experiencing the rendering issue.

Screenshot 2022-11-30 070129

commented

Issue happens on forge 43.1.58 with Functional storage 1.19.2-1.0.7 also

commented

i would like to add on to this that when you go into spectate and fly into the drawer the items are still there, they are just not far enough forward to clip through the face of the drawer

commented

Just FYI, I think I'm seeing the same issue in DireWolf20 1.19; I just started moving from chests to drawers, and only cubed blocks are showing on the face of my drawers, the rest just have the numbers without an image of the item.

commented

I am having the same issue with a custom pack that i created.

Forge 43.2.0

image

commented
commented

While the forge regression is responsible for the items not drawing I also found an issue with create shafts and cogs not displaying properly (in Forge 43.1.55). They are 3D objects in the world and inventory but aren't block-shaped, so the positioning for blocks doesn't work on them properly.

2022-12-14_19 15 33
2022-12-14_19 15 36

It might be a better idea to position 3D items/blocks and squish them flat-ish to the center of the drawer face instead of offsetting them in the way you're currently doing, it should look pretty much the same for regular blocks but would allow irregularly shaped 3D items/blocks to display properly as well. Code below might explain what I mean better.

BakedModel model = Minecraft.getInstance().getItemRenderer().getModel(stack, Minecraft.getInstance().level, null, 0);
if (model.isGui3d()){
    matrixStack.translate(0,0, someTranslationToCenterThingToFaceOfDrawer);
    matrixStack.scale(0.75f, 0.75f, 0.1f); // changed z-scale to 0.1 to squish model
} else {
    matrixStack.scale(0.4f, 0.4f, 0.4f);
}
commented

It's a forge bug, it will be fixed when forge fixes it

commented

So when is the update that fixes this issue?

commented

Fixed in forge 43.2.3

commented

I am not sure if older packs can upgrade forge to resolve this issue, for them I offer this semi-workaround, which might be obvious to some but not others.

To remedy this situation

image

Use the drawers that allow textures to be applied and use a transparent block for the drawer slot, here's an example:

image
(be sure not to use chipped or other invalid blocks like fences or walls if you are in a version where that issue still exists)

And you should be able to see the objects again like shown here:

image

This example was done in the latest (as of 3-12-2023) version of Stoneblock 3.

commented

@Buuz135 - I'm having this same issue with All The Mods 9-0.2.27, which is running with Forge 47.2.16. It happens after I pull an item out of the drawer. It seems to reset if I unlock and then relock the drawer.
Let me know if I can help get any debugging information or open a ticket with the forge team.