Functional Storage

Functional Storage

31M Downloads

[1.21] Able to take out drawer upgrades when contents are over base limit

EvilNick2 opened this issue ยท 2 comments

commented

Functional Storage Version: 1.4.2

Titanium Version: 4.0.36

When a drawer has an upgrade with over 2048 items in the drawer, the upgrade can still be taken out even thought the amount exceeds the limit

commented

Fixed in c0edbd3

commented

Just to note, this also leads to crashes and block entities not being able to serialize.

To reproduce:

  • fill up a drawer with any item
  • add a storage upgrade, and a few more stacks of the item
  • remove the storage upgrade
  • try to insert another item
  • you'll get a jumbo itemstack in your inventory, the size of the stack being the overflow excess
  • game then crashes when it tries to save your inventory due to the jumbo itemstack

This causes similar problems with block entities that try to insert into such a drawer via IItemHandler#insertItem() - a jumbo itemstack will be returned, and if that stack is stored in a serializable field, serialization will fail - e.g. FTBTeam/FTB-Mods-Issues#1603