[1.11.2-1.92] Dupe while breaking furnus

Question

[1.11.2-1.92] Dupe while breaking furnus

kreezxil opened this issue 8 years ago · 10 comments

kreezxil commented 8 years ago

There is no crash report, I tested this with Forge build 2282 plus Furnus and JEI.

https://youtu.be/SBfLknlHa68 <-- demonstration

KidsDontPlay · Answer 1 · 2017-04-12T12:04:27.000Z

~~which limelib version do you use?~~
that's a bug in limelib 1.5.3.
you may try 1.5.2

kreezxil · Answer 2 · 2017-04-12T12:12:20.000Z

I'm using 1.11.2-1.5.3, I use the Curse Launcher so it keeps things current for me.

…

On Wed, Apr 12, 2017 at 7:04 AM, MrRiegel ***@***.***> wrote: which limelib version do you use? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADs0iGNOGovTy45FvRoM-by9vyVsFhhsks5rvL3MgaJpZM4M7SO1> .

kreezxil · Answer 3 · 2017-06-04T13:39:11.000Z

Oh, yeah, hadn't really had my coffee yet. The version used in this last duping was 1.54. I'm reverting to 1.52 now.

kreezxil · Answer 4 · 2017-06-03T21:21:57.000Z

this issue has returned in version 1.11.2 - 1.93 I haven't tested it with the furnus, but it is happening with the pulvus. Also using forge build 2311

KidsDontPlay · Answer 5 · 2017-06-04T10:35:41.000Z

latest limelib version?

kreezxil · Answer 6 · 2017-06-04T11:53:03.000Z

Oh right I did update to it. So frustrating to have to remember to use the older one. Maybe you should archive the bugged version.

…

On Jun 4, 2017 5:35 AM, "MrRiegel" ***@***.***> wrote: latest limelib version? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADs0iCyc8p0QeE9wt-WuIKwFkHxw5BjFks5sAoh9gaJpZM4M7SO1> .

kreezxil · Answer 7 · 2017-06-05T22:32:05.000Z

i deprecated to 1.52 the dupe is still ocurring, has to be forge related, my forge is now on build 2314.

kreezxil · Answer 8 · 2017-06-08T00:11:53.000Z

I'm looking at your limelib and have a couple of questions.

In the file: https://github.com/MrRiegel/LimeLib/blob/1.11/src/main/java/mrriegel/limelib/block/CommonBlockContainer.java

The function breakBlock starting at line 44 appears to do the same thing as the function onBlockHarvested at line 117. Immediately what comes to mind is that Minecraft will hit both of those when I break my block and create a double.

Also in the function breakBlock you don't call the super as other mods in 1.11.2 do. For example in Better With Mods, the Steel Anvil which also spews it's contents into the world and then itself to the world, https://github.com/BeetoGuy/BetterWithMods/blob/1.11/src/main/java/betterwithmods/common/blocks/BlockSteelAnvil.java lines 110 to 115. On 114 it calls the super.

If you search the better with mods repository for onBlockHarvested there are no results returned. My money is on that function causing the duping.

KidsDontPlay · Answer 9 · 2017-06-08T10:38:57.000Z

in line 117 it drops the furnus, in line 44 it drops the content of the furnus.
super.breakBlock() just removes the tile entity. I do it in line 49.

I need to override onBlockHarvested() to drop the block when the tile entity wasn't removed yet.

I tested it with only limelib 1.5.4, furnus 1.93 and forge 13.20.0.2314 installed and I cannot reproduce your bug. Do you use a normal pickaxe?

kreezxil · Answer 10 · 2017-06-09T16:13:09.000Z

I found it! It's an incompatibility with MultiMine by AtomicStryker. Weird why no other blocks from other mods duplicate in conjunction with his mod. Multimine holds the state of the blocks breakage, so that you can come back to breaking it later without losing your progress in breaking it. Also useful for multiplayer so that more than one player can help break blocks even faster than if one were doing all the work. He's on github so I shall open a ticket there and cross reference this thread.

Share to