Future MC

Future MC

14M Downloads

Bees + Dynamic Trees Compatibility

CalaMariGold opened this issue · 29 comments

commented

Bee hives don't spawn when Dynamic Trees are present. It would be amazing if we could get compatibility for this!

Thank you!

commented

Hey @mooofins have you been able to look at this issue with OTG and FMC/Bees?

commented

No, sorry. My last and final update on the other bug was where I left off.

commented

Small update on this issue, i talked with mooofins and he won't work on this issue: I don’t really want to look into the bees one tbh; too open ended.
Tottaly understandable and i do want to thank him for his time and effort!

I talked to the dev and he had some work put into it, but hasn't been able to get around of this just yet!

commented

I talked with Smileycorp and he said the following to solve this issue:

for dynamic trees compatability you could hook into the SpeciesPostGenerationEvent to figure out when a tree is being generated and from there figure out if to and generate a beehive at the tree's location

for most modded trees you should be able to detect their generation using the DecorateBiomeEvent.Decorate, unless they do weird things with their trees, using the EventType.TREE, and add beehives using that, i'd probably suggest running it at EventPriority.LOWEST and set recieveCancelled to true so you can generate the hives after other mods replace generated trees with their own

i'm sorry i don't rally have much time at the moment to actually add the fix and also the mod is written in kotlin which i don't really know, but I think the principles should work for futuremc

Perhaps this can help clarify the issue more, so We can find a solution!

here is some stuff I prepared so anyone can easily setup the test environment!
https://cdn.discordapp.com/attachments/864829008134668318/901182038823010344/allbiomesinfmcformat.txt (A valid confix that makes almost every compatible tree have a beehive)

Seed: -1223960747440536249

Modpack https://cdn.discordapp.com/attachments/864829008134668318/901179544747270165/OTGFMC.zip

953AA834-D937-4594-BDFA-2B3005D3341A
5E979C6A-34C0-483F-B053-EFD1A4FF4FD8
E8615929-560C-4BC8-B577-EE0C00573034

commented

Also small extra bit of code from harvestcraft who places beehives on the leafes:

public void init(FMLInitializationEvent e) {
  GameRegistry.registerWorldGenerator(new BushWorldGen(), 0);
  GameRegistry.registerWorldGenerator(new FruitTreeWorldGen(), 0);
  GameRegistry.registerWorldGenerator(new BeehiveWorldGen(), 0);
        
  onBlocksAndItemsLoaded();
}

Source: https://github.com/MatrexsVigil/harvestcraft/blob/master/src/main/java/com/pam/harvestcraft/proxy/CommonProxy.java#L60

commented

3E0148DB-84C4-4490-892E-999FB1F49D6C
041E6C4D-0BF6-453F-B30B-A6231949617D

we’re getting close with the bees!!! Thanks to thedarkcolour!

commented

It seems the change is on public repo to include bees everywhere! But it seems that the mod doesn't compile anymore due to:
https://pastebin.com/0WXHEEf2

As soon as thedarkcolour pushes a fix, the jar actually will be there in the summary tab of that commit!
I've tried the previous commits, but it seems the bug came from the change itself sadly.
I'll throw the (preview) jar here once that's out :-)

commented

FutureMC (2).zip

here’s the working preview of FMC where bees can spawn in OTG!

it’ll eventually be released officially after some more bug are fixed :)

ill unsub from this thread as it’s only for dynamic trees which I’m not interested in.

take care everyone!

commented

Seems to be a bug which crashes the game, reported and hopefully it’ll be fixed soon!

commented

Latest update support Biome Bundle!
Did ask if it’s also possible to do Biome Bundle o Plenty!

commented

It's great it works with Biome Bundle. But... uh..

This issue was specifically about supporting Dynamic Trees. Is that or is that not happening?

commented

Not sure, ya can try
This issue is also about bees :p I’m in for the bees haha

commented

1unknown
unknown
biomes o plenty is a work in progress because some of the trees are irregular -tdc

commented

I'm moving on from minecraft, i won't be keeping an eye progress on the bee part.

commented

bees would bee the bees knees

commented

I'll see what Dynamic Trees does and if I can hook into it.

commented

This compatibility would make a world of difference. Looking forward to this!

commented

I would also greatly appreciate this particular compatability!

commented

Another person excited for bees/dynamic trees compat! Thanks for your work! <3

commented

You mentioned on Discord getting bee nests to spawn, though they glitched out as the tree grew. If you haven't scrapped the code, would you consider adding this as an experimental feature in config, disabled by default? Floating nests are better than no nests. If not, perhaps I could take a crack at it.

commented

Any updates on this?

commented

I've gotten it to work partially.

commented

It's been half a year since last message, @thedarkcolour are you ever going to work on this or no

commented

I forgot to reply here. I tried it at one point and it did not work as intended but I think I could try again

commented

(btw @APlayGames it ended up putting hives on every single dynamic tree 😆)

commented

This is also gonna be fixed with the support of this #234

commented

Any idea when an update with that might happen?

commented

It would be awesome if you could get the time to look into it! Other bees implementations are... lacking

commented

I would still be excited about this if you have the time @thedarkcolour :)