Restructurer is causing a server crash
Shedao-Shai opened this issue ยท 4 comments
Versions ("Latest" is NOT a version):
- Minecraft: [1.16.5] (required)
- Forge: [36.1.0] (required)
- Gaia Dimension: [1.16.5-1.3.3-unofficial-4] (required)
Crash Report
(https://gist.github.com/thefish548/638c6017320609181c97743672613051)
To Reproduce:
Steps to reproduce the behaviour. This is required for easier diagnosis:
- Insert bismuth, gummy glitter and pink essence into a restructure via hopper (bismuth via top, fuels via back same as a furnace and output out the bottom)
- Server goes down when this combination is active, unknown if it is during the attempted output-input of items or because its attempting to output more items than there is space to do so
Additional context
This was discovered on the twilight forest testing server
Can't remember if I put a failsafe in here, but also keeping it open in case it is still happening.
As a note for tracking:
The issue is happening in getItemBurnTime(). Specifically, the null is happening on return, which means somehow, in between the check for the stack being empty and if the item in the stack can burn, it becomes null. It isn't the maths at fault unless somehow the two slots equal 0, but order of operations dictate diving zero by any number isn't a problem but dividing by zero is.
Basically: a fuel slot tried to say it's not empty when it is. Or at least, a null apparently doesn't equate to null. Worth noting also that, per tick, it is evaluated that all three stacks have contents; even if one is empty, it should not continue. While it would be possible to do a null check, this shouldn't even be necessary.
As another note: none of the items intersect category, ie. one is not both a fuel and ingredient. This means there's no interaction between inputs into a slot.
(by the way, tell the admins to enable the forge config option to delete errored tile entities, in server configs)