Apothic Pinnacle gate imploding
LordHarkon opened this issue ยท 8 comments
I have updated both apotheosis and gateways to eternity to latest version on ATM10, and I tried to spawn Gate Pearl - Gateway of the Apothic Pinnacle. I have tried both in the overworld and in the mining dimension (infinitely flat world) and both times I get The Gateway imploded because there was not enough space to spawn the next wave which shouldn't happened since I have plenty of empty space in both dimensions. In the mining dimension it failed after second wave, and in the overworld it failed after third wave.
Versions:
Apotheosis 8.4.0
Gateways to Eternity 5.1.0
Forge 21.1.203
ATM10 4.10
I just checked the server console, and in overworld I am getting this error when the wave fails:
[23:39:16] [Server thread/ERROR] [apotheosis/]: An EliteWaveEntity has an ubound elite holder DynamicHolder{apothic_elites / apotheosis:overworld/craig}!
And in the mining dimension:
[23:41:08] [Server thread/ERROR] [apotheosis/]: Failed to resolve a random invader when generating an InvaderWaveEntity!
ATM10 has a very stale workaround in place that deletes the Elite used by this gateway. You'll need to remove this script file https://github.com/AllTheMods/ATM-10/blob/main/kubejs/server_scripts/mods/Apotheosis/adventure.js#L6
ATM10 has a very stale workaround in place that deletes the Elite used by this gateway. You'll need to remove this script file https://github.com/AllTheMods/ATM-10/blob/main/kubejs/server_scripts/mods/Apotheosis/adventure.js#L6
That fixed it for the overworld. Fighting it in the mining dimension still gives the error: [Server thread/ERROR] [apotheosis/]: Failed to resolve a random invader when generating an InvaderWaveEntity!
Just so you know.
That is... not unexpected, but the UX there is not great. There's no invaders defined for that dimension, so it can't resolve anything and thus doesn't function.
But ideally it should tell you that before you try to open it.
That is... not unexpected, but the UX there is not great. There's no invaders defined for that dimension, so it can't resolve anything and thus doesn't function.
But ideally it should tell you that before you try to open it.
Maybe if the dimension is not recognized it should automatically default to the overworld ones? Or simply fallback to some default ones.
Just a suggestion.
@Shadows-of-Fire do you think it'd make sense to change the error.gateways.wave_failed from the very specific "The Gateway imploded because there was not enough space to spawn the next wave" to something about "The Gateway imploded because it failed to spawn the next wave, check spacing and dimension" or just a more generic "The Gateway imploded because it failed to spawn the next wave here" so it doesn't lead you too much to think about the spacing (the more vague latter "here" can both imply spacing and dimension)?
It seems to be misleading people here over at FTB discord too where people try to use it in e.g. JAMD mining dimensions and wondering why there's not enough space and why it keeps failing.
Unless of course in Wave/spawnWave there could be a more complex way to catch the issue from Apotheosis failing to spawn it other than the simple entity == null check, so that it could have its own FailureReason.
"The Gateway imploded because it failed to spawn the next wave here"
This error message is as bad as
"Something went wrong."
Bane of my existence, they are. I can't debug w hats wrong if the error messages are vague like this. Would highly recommend against going even more vaguer than "Gateway failed because not enough space" if the issue isn't space...
The reason I proposed more vague is because it's more correct. I think it's better to have a more vague/general error that's technically correct, than an error being very precise but incorrect, because now it specifically saying there isn't enough space means people are trying to make more and more space and wonder how much space it needs, when their issue is it's in the wrong dimension.
If it's more generic, they're not any wiser to what the issue is here, but at least they're not being pointed to an entirely wrong reason which to me seems worse. So at that point at least they might be more open to looking into what the issue is, instead of getting hung up on confirmation bias.
Either way that'd have been a quick stop gap solution until better UX (e.g. checking if Apotheosis invaders can spawn in the dimension and if not telling the user that's why the gateway won't succeed). If you have a better placeholder solution feel free to mention it too, I just couldn't think of something better.
(And if the message is vague instead of misleading, at least it leaves more general debugging on the table than making wrong assumptions, in which case at least it'd be quick to spot the issue when checking logs)