Genshin Instruments

Genshin Instruments

Mods
1M Downloads

Translations Required - Chinese

StavWasPlayZ opened this issue · 5 comments

commented

Hello,

I am in the process of shipping Genshin Instruments v4,0, and there are a bunch of new translation keys that are in need of translation.

Expand to see diff (en_us.json) 
diff --git a/src/main/resources/assets/genshinstrument/lang/en_us.json b/src/main/resources/assets/genshinstrument/lang/en_us.json
index da713ba..3a168f0 100644                                                                                                     
--- a/src/main/resources/assets/genshinstrument/lang/en_us.json                                                                   
+++ b/src/main/resources/assets/genshinstrument/lang/en_us.json
@@ -9,7 +9,8 @@                                                                                                                   
     "item.genshinstrument.windsong_lyre": "Windsong Lyre",                                                                       
     "item.genshinstrument.floral_zither": "Floral Zither",                                                                       
     "item.genshinstrument.vintage_lyre": "Vintage Lyre",                                                                         
-    "item.genshinstrument.glorious_drum": "Arataki's Great And Glorious Drum",                                                   
+    "item.genshinstrument.glorious_drum": "Arataki's Great and Glorious Drum",                                                   
+    "item.genshinstrument.nightwind_horn": "Nightwind Horn",                                                                     
                                                                                                                                  
                                                                                                                                  
     "soundCategory.record": "Instruments",                                                                                       
@@ -84,7 +85,8 @@                                                                                                                 
     "button.genshinstrument.zither.soundType.new": "New",                                                                        
                                                                                                                                  
                                                                                                                                  
-    "button.genshinstrument.label.do_re_mi": "Do Re Mi",                                                                         
+    "button.genshinstrument.label.do_re_mi": "do re mi",                                                                         
+    "button.genshinstrument.label.do_re_mi.description": "Labels will be of the musical notation \"do re mi.\"",                 

     "genshinstrument.label.do": "do",
     "genshinstrument.label.re": "re",
@@ -99,10 +101,19 @@


     "button.genshinstrument.label.keyboard_layout": "Keyboard",
+    "button.genshinstrument.label.keyboard_layout.description": "Labels will be of your local keyboard layout",
     "button.genshinstrument.label.qwerty": "Keyboard (QWERTY)",
-    "button.genshinstrument.label.note_name": "Note Name",
-    "button.genshinstrument.label.abc": "ABC",
+    "button.genshinstrument.label.qwerty.description": "Labels will be of the QWERTY keyboard layout",
+    "button.genshinstrument.label.note_name": "ABC",
+    "button.genshinstrument.label.note_name.description": "Labels will be of the musical notation \"ABC\"",
+
+    "button.genshinstrument.label.fixed_abc": "Fixed ABC",
+    "button.genshinstrument.label.fixed_abc.description": "ABC labels that are not affected by custom transpositions (pitch)",
+    "button.genshinstrument.label.fixed_do_re_mi": "Fixed do re mi",
+    "button.genshinstrument.label.fixed_do_re_mi.description": "do re mi labels that are not affected by custom transpositions (pitch)",
+
     "button.genshinstrument.label.none": "No Label",
+    "button.genshinstrument.label.none.description": "",

     "button.genshinstrument.label.don_ka": "Don-Ka",

@@ -121,9 +132,12 @@
     "genshinstrument.advancements.main.vintage_lyre.description": "Play the Vintage Lyre",

     "genshinstrument.advancements.main.glorious_drum.title": "Totally Not a Scam",
-    "genshinstrument.advancements.main.glorious_drum.description": "Play Arataki's Glorious Drum",
+    "genshinstrument.advancements.main.glorious_drum.description": "Play Arataki's Great and Glorious Drum",

     "genshinstrument.advancements.main.floral_zither.title": "Incognito Player",
-    "genshinstrument.advancements.main.floral_zither.description": "Play the Floral Zither"
+    "genshinstrument.advancements.main.floral_zither.description": "Play the Floral Zither",
+
+    "genshinstrument.advancements.main.nightwind_horn.title": "The Final Symphony",
+    "genshinstrument.advancements.main.nightwind_horn.description": "Play the Nightwind Horn"

 }

Notably (though not fully all):

    "item.genshinstrument.nightwind_horn": "Nightwind Horn",

    "button.genshinstrument.label.do_re_mi.description": "Labels will be of the musical notation \"do re mi.\"",
    "button.genshinstrument.label.keyboard_layout.description": "Labels will be of your local keyboard layout",
    "button.genshinstrument.label.qwerty.description": "Labels will be of the QWERTY keyboard layout",
    "button.genshinstrument.label.note_name.description": "Labels will be of the musical notation \"ABC\"",
    "button.genshinstrument.label.fixed_abc": "Fixed ABC",
    "button.genshinstrument.label.fixed_abc.description": "ABC labels that are not affected by custom transpositions (pitch)",
    "button.genshinstrument.label.fixed_do_re_mi": "Fixed do re mi",
    "button.genshinstrument.label.fixed_do_re_mi.description": "do re mi labels that are not affected by custom transpositions (pitch)",

    "genshinstrument.advancements.main.nightwind_horn.title": "The Final Symphony",
    "genshinstrument.advancements.main.nightwind_horn.description": "Play the Nightwind Horn",

I have manually translated some of the keys, but I cannot ascertain that they are perfect.
Would appreciate a PR on that matter.

Do note that it's on the dev branch.

CC @SteveNotSet

Thanks!

commented
commented

Do take your time!

Regarding your concern, I think the closer to the source the better - though I will take your personal judgement to be the end result. Ultimately, this is up to you, and what you think is best representative of the notation.

Also, I'd recommend viewing & replying in GitHub itself than by mail directly, since mail contains some undecipherable Gibberish for some reason.

Nevertheless, Thanks again!

commented

Sure, no issues - per your comfort.

I will get into merging right away.

Thank you so so much! :]

commented

Finished new translations, and recovered my other translations not synced in the last commit.

I am sorry that I replied to you by email because accessing to Github behind the GFW is unstable (sometimes very fast, sometimes connection timed out) and mailing is a more convenient way. The Gibberish at the end of the reply is my email's signature, just ignore it. I will reply via GitHub direcly if possible.

commented

#17

  • 👍1