Geolosys

Geolosys

5M Downloads

Ore with out sample

Mimic0445 opened this issue · 4 comments

commented

I am adding some mod ores that you haven't added support for but...

The 1.12.2 version does not allow an ore with out an accompanying sample. (Crashes on world gen)
I set the sample to minecraft:air. This effectively makes an ore have no sample.

The side effect is that now the Prospector's Pick detects air making it useless because it always detects air first.

I would suggest changing the mod to allow an ore to have no sample. Or create a black list of blocks the Prospector's Pick can not detect.

commented

Sorry to dig up old dirt! I'm working on a huge refactor that allows you to set a sample as null with any chance (including 100%), so this would technically work. Unfortunately I only have so much time in the day so this feature will only be for 1.16 🙁

Closing as I know this feature will be out soon (ideally today!) and will not be able to be backported due to time constraints.

commented

This will literally be the last update I make in 1.12, but you make a good point.

Will you try this build out and let me know if it solves the prospector's pick detecting air?

commented

Thanks for the quick update.

The build you linked shows "geolosys.pro_pick.tooltip.found_surface" if I use it above an ore deposit and "geolosys.pro_pick.tooltip.nonefound_surface" if I am not above an ore deposit.

I believe this means your change is working correctly but I am missing localization files.

commented