Geolosys

Geolosys

5M Downloads

[1.12.2] [1.8.2] Disable osmium in config, still spawns / drops osmium.

codetaylor opened this issue ยท 3 comments

commented

MC: 1.12.2
Forge: 14.23.0.2550
Geolosys: 1.8.2

What happens:
When I disable osmium in the config, platinum ore still drops osmium clusters and samples on the surface still drop osmium.

What I expect to happen:
When I disable osmium in the config, platinum ore drops only platinum cluster and the surface samples drop only platinum.

Notes:
This is a great mod, I love it! Thank you for making it. :)

I believe that the issue of the ore dropping osmium even when it is disabled is because of this line (BlockOre.java#L114). I believe that it should drop platinum here instead of osmium. I also notice that the switch in BlockSample#getDrops() method does not respect the config values in this case (BlockSample.java#L194).

I would like to mention that this same issue exists for uranium and yellorium, and for similar reasons. I think that this line (BlockOre.java#L135) should drop uranium instead of yellorium and, again, the switch in BlockSample#getDrops() doesn't respect the config values in this case (BlockSample.java#L206).

I am happy to submit a PR to solve this issue, but I don't want to step on your toes and thought it would be a good idea if I talked to you first.

Thanks again! :)

commented

Oops, I was "code drunk" at the time. That's what I get for coding for work and three senior-level university classes and fun. :P

Fixing now!

commented

Thanks! :)

Looks like the BlockSample will still drop osmium and yellorium regardless of the config setting though. (case 8 and 9 of the switch statement)

commented

Right you are. Just changed around that mechanic.. I don't know why I was calculating them anyways