1.20.1 - GOML Text is using internal strings only
LokeYourC3PH opened this issue · 22 comments
In order to show what I mean better, here a screenshot:
As you can see, all text is merely showing as "text.goml.xxx..."
This happens on Fabric 1.20.1 and the latest GOML version.
It's Minecraft Comes Alive
Ugh... I always knew this mod was invasive and always caused some issues back in the days...
Well anyhow, as no other mod seems to suffer from it, I wonder why your mod would be affected by it 🤔
Ok, I need you to generate mixin debug output. You can do that by adding
-Dmixin.debug.export=trueas java flag in your launcher. Then you need to send me.mixin.out/net/minecraft/class_2588.class, as it might help me to debug that
Sure, here you go:
class_2588.zip
This class looks fine... hmm. Fun...
Could you send anything starting with class_2477? in same folder
This class looks fine... hmm. Fun...
Could you send anything starting with
class_2477? in same folder
I'll do you a better one, I'll just send you the entire class folder:
See issue above. Minecraft Comes Alive breaks vanilla feature that makes MC use fallback from translatable text. And GOML uses that for server side translations.
See issue above. Minecraft Comes Alive breaks vanilla feature that makes MC use fallback from translatable text. And GOML uses that for server side translations.
Alright, so I will just have to wait for MCA to update then. But how come other mods aren't affected by this, then? Is no other mod using that feature then?
It's one of your client mods breaking it
I suppose it's an incompatibility then. I'll figure out which one.
Note that, it also doesn't happen to any other mod so...
Sent your client modlist
Sure, here you go:
3dskinlayers-fabric-1.5.3-mc1.20.jar
abverticaledition-1.0.3b-fabric-mc1.20.jar
AdditionalEnchantedMiner-1.20.1-fabric-20.0.801.jar
AdditionalStructures-1.20.x-(v.4.2.0).jar
ae2wtlib-15.0.1-beta.jar
agape_space-1.2.0.jar
alloy-forgery-2.0.21+1.20.jar
almostunified-fabric-1.20.1-0.5.0.jar
alternate-current-mc1.20-1.7.0.jar
AmbientSounds_FABRIC_v5.2.20_mc1.20.1.jar
appliedenergistics2-fabric-15.0.2-alpha.jar
architectury-9.0.8-fabric.jar
areas-1.20.1-5.0.jar
argonauts-fabric-1.20-0.0.0.jar
async-locator-fabric-1.20-1.3.0.jar
authme-7.0.1+1.20.jar
automated-crafting-1.4.13+MC1.20-1.20.1.jar
azure-paxels-1.20.1-1.0.5.jar
badpackets-fabric-0.4.1.jar
bclib-3.0.10.jar
better-end-4.0.7.jar
better-nether-9.0.7.jar
betterbeds-1.3.0-1.19.3.jar
bettercombat-fabric-1.7.2+1.20.1.jar
bettercommandblockui-0.4.2-1.20.jar
BetterFurnaces-1.20.1-0.1.4-fabric.jar
BetterPingDisplay-Fabric-1.20.1-1.1.1.jar
biggerspongeabsorptionradius-1.20.1-3.1.jar
block-event-separator-mc1.20-1.3.0.jar
cadmus-forge-1.20-0.0.1.jar
cardinal-components-api-5.2.1.jar
carrier-1.12.0.jar
cauldron-dyeing-1.0.10.jar
cc-tweaked-1.20.1-fabric-1.105.0.jar
ChatImage-1.1.7+1.20.1+fabric.jar
chatsigninghider-1.20.1-1.0.0.jar
chat_heads-0.10.16-fabric-1.20.jar
chunkloaders-1.2.3-fabric-mc1.20.jar
chunksfadein-v1.0.1-1.20.jar
cinderscapes-4.0.6.jar
ClearDespawn-fabric-1.20.1-1.1.11.jar
clientsidedcrystals-1.1.0-1.20.jar
cloth-config-11.0.99-fabric.jar
Clumps-fabric-1.20.1-12.0.0.2.jar
collective-1.20.1-6.62.jar
compact-chat-2.0.1.jar
compacthelpcommand-1.20.1-2.3.jar
continuity-3.0.0-beta.2+1.20.jar
Controlling-fabric-1.20.1-12.0.1.jar
CorgiLib-fabric-1.20.1-4.0.0.0.jar
CreativeCore_FABRIC_v2.10.23_mc1.20.jar
cristellib-1.1.0.jar
dark-loading-screen-1.6.14.jar
deathlog-0.3.2+1.20.jar
Debugify-1.20.1+1.1.jar
disableaccessibilityscreen-1.0.1.jar
DisableInsecureChatToast-mc1.20-1.1.0.jar
disable_compliance_notification-v1.4.1+fabric-1.20.1.jar
do-a-barrel-roll-3.0.1+1.20-fabric.jar
doubledoors-1.20.1-5.0.jar
dynamic-fire-overlay-1.0.0.jar
elytraslot-fabric-6.3.0+1.20.1.jar
enchantips-1.1.0.jar
enhancedblockentities-0.9+1.20.jar
Enhanced_Celestials-fabric-1.20.1-5.0.0.2.jar
entangled-1.3.14-fabric-mc1.20.jar
expandedstorage-10.0.0-beta.3+1.20-fabric.jar
explosive-enhancement-1.1.0-1.20.x.jar
fabric-api-0.84.0+1.20.1.jar
fabric-language-kotlin-1.9.6+kotlin.1.8.22.jar
FactoryAPI-1.20.1-0.1.8-fabric.jar
fallingleaves-1.15.1+1.20.1.jar
fallingtrees-0.1.jar
fancymenu_fabric_2.14.7-3_MC_1.20.jar
ferritecore-6.0.0-fabric.jar
fishing_ruler-1.0.2-mc1.20+.jar
fluidvoidfading-1.1.0.jar
ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric.jar
fusion-1.0.0-fabric-mc1.20.jar
gamemenuremovegfarb-fabric-mc1.19.4-2.1.1.jar
ghastly-wail-1.1.3+MC1.20-1.20.1.jar
goml-1.9.0+1.20-rc1.jar
gottagofast-1.1.0.jar
gravestones-v1.15.jar
HuskHomes-Fabric-4.4.1-e1e0c73.jar
illusory-walls-0.1.0+1.20.jar
ImmediatelyFast-1.1.15+1.20.1.jar
immersive-portals-3.1.0-mc1.20.1-fabric.jar
indium-1.0.18+mc1.20.jar
InventoryProfilesNext-fabric-1.20-1.10.4.jar
iris-mc1.20-1.6.4.jar
itemcollectors-1.1.7a-fabric-mc1.20.jar
jeed-1.20-2.1.5-fabric.jar
jei-1.20.1-fabric-15.2.0.22.jar
joinleavemessages-fabric-1.6.0.jar
journeymap-1.20.1-5.9.9-fabric.jar
kleeslabs-forge-1.20-15.0.0.jar
konkrete_fabric_1.6.1_MC_1.20.jar
krypton-0.2.3.jar
lambdynamiclights-2.3.1+1.20.1.jar
language-reload-1.5.8+1.20.1.jar
largefluidtank-fabric-20.2.0.jar
lazydfu-0.1.3.jar
leaves-us-in-peace-1.0.17+MC1.20-1.20.1.jar
letmedespawn-fabric-1.20-1.1.0.jar
libIPN-fabric-1.20-3.0.2.jar
linkedstorage-1.5.2-1.20.jar
lithium-fabric-mc1.20.1-0.11.2.jar
lmft-1.0.1+1.20-fabric.jar
loadmyresources_fabric_1.0.4-1_MC_1.20.jar
logcleaner-1.0.0.jar
lunade-fastanim-1.6-1.20.jar
make_bubbles_pop-0.1.1.jar
MapFrontiers-1.20.1-2.6.0beta1-fabric.jar
mcpitanlibarch-1.6.10-1.20.1-fabric.jar
Measurements-fabric-1.20.1-2.0.0.jar
memoryleakfix-fabric-1.17+-1.1.1.jar
memoryusagescreen-fabric-mc1.20-1.9.0.jar
minecraft-comes-alive-7.5.3+1.20.1-universal.jar
mixintrace-1.1.1+1.17.jar
modern-glass-doors-5.1.0+1.20-and-later.jar
modernfix-fabric-5.0.4+mc1.20.1.jar
modmenu-7.1.0.jar
moonlight-1.20-2.5.12-fabric.jar
morechathistory-1.19.1-1.1.1.jar
MouseTweaks-fabric-mc1.20-2.25.jar
movingelevators-1.4.3-fabric-mc1.20.jar
MTR-fabric-1.20-3.2.2-hotfix-1.jar
neruina-1.0.0-fabric+1.20.1.jar
no-invincibility-frames-0.2+1.20.1.jar
no-report-button-fabric-1.5.0.jar
no-resource-pack-warnings-1.3.0.jar
no-sneaking-over-magma-1.0.18+MC1.20-1.20.1.jar
no-telemetry-1.7.0.jar
NoChatReports-FABRIC-1.20.1-v2.2.1.jar
nonarrator-1.0.1.jar
Nosey-fabric-1.20.1-0.5.0.jar
notenoughanimations-fabric-1.6.4-mc1.20.jar
ocrenderfix_sodium-fabric-1.2.0.jar
online_detector-1.20-6.0.0.jar
owo-lib-0.11.0+1.20.jar
Pehkui-3.7.6+1.14.4-1.20.1.jar
PerfectAccuracy-1.2-1.19.jar
Philips-Ruins1.20.1-1.1[Fabric].jar
PipePlus-1.20-0.5.3.jar
player-animation-lib-fabric-1.0.2-rc1+1.20.jar
PresenceFootsteps-1.9.0.jar
prometheus-fabric-1.20-0.0.0.jar
randommobsizes-fabric-1.20.1-1.3.jar
rare-ice-0.6.0.jar
reacharound+1.20-1.1.2.jar
realisticbees-1.20.1-3.4.jar
RebornCore-5.8.2.jar
rechiseled-1.1.0a-fabric-mc1.20.jar
reeses_sodium_options-1.5.1+mc1.20-build.74.jar
RegionsUnexploredFabric-0.4.1+1.20.1.jar
resourcefulconfig-fabric-1.20-2.0.0.jar
resourcefullib-fabric-1.20.1-2.1.1.jar
RestoreChatLinks-1.19.3-0.2.1.jar
riverredux-0.3.1.jar
scalable-cats-force-fabric-2.0.0.jar
Searchables-fabric-1.20.1-1.0.1.jar
sfcr-1.7.4-mc1.20-fabric.jar
Sheep-Squeak-fabric-1.20.1-1.2.0.jar
simplepipes-all-0.11.0-pre.1.jar
smoothchunk-fabric-1.20.1-3.0.jar
sneaky-mc1.20.1-1.0.4+1e9488a0.jar
sodium-blendingregistry-0.4.10.1.jar
sodium-extra-0.4.20+mc1.20-build.103.jar
sodium-fabric-mc1.20-0.4.10+build.27.jar
soundphysics-fabric-1.20.1-1.1.1.jar
spawn-animations-1.9.1.jar
speedometer-1.3.0.jar
starlight-1.1.2+fabric.dbc156f.jar
supermartijn642configlib-1.1.6-fabric-mc1.20.jar
supermartijn642corelib-1.1.9-fabric-mc1.20.jar
supplementaries-1.20-2.5.13-fabric.jar
swingthrough-1.0.2+1.19.jar
TechReborn-5.8.2.jar
tectonic-mod-mc1.20-v2.jar
TerraBlender-fabric-1.20.1-3.0.0.164.jar
tesseract-1.0.34-fabric-mc1.20.jar
tooltipfix-1.1.1-1.20.jar
Towns-and-Towers-1.11-Fabric+Forge.jar
trashcans-1.0.18-fabric-mc1.20.jar
travelers-backpack-1.20.1-9.1.0.jar
trinkets-3.7.0.jar
universal_shops-1.3.2+1.20.1.jar
vanish-1.4.2+1.20.jar
visuality-0.7.0+1.20.jar
visualoverhaul-fabric-5.0.1.jar
vmp-fabric-mc1.20.1-0.2.0+beta.7.96-all.jar
walljump-fabric-1.20.1-1.3.6.jar
waveycapes-fabric-1.4.0-mc1.20.jar
wirelesschargers-1.0.8-fabric-mc1.20.jar
wirelessredstone-fabric-1.20.1-1.0.0.jar
wormhole-1.1.12-fabric-mc1.20.jar
wthit-fabric-8.1.1.jar
yet-another-config-lib-fabric-3.0.2+1.20.jar
One that I could imagine to cause it, would be
tooltipfix-1.1.1-1.20.jar
, so I'll try removing that one first.
EDIT: It was not tooltipfix, I removed it, issue persists.
Nothing stands out hmm. Does it work in singleplayer or also not?
Apparently it's only on Multiplayer, it does not happen in Singleplayer worlds.
I'll send you a list of the mods list from the server side, it's almost the same as client side but with some server only improvements.
Server list shouldn't matter. Could you install some nbt viewer mod like this one (https://modrinth.com/mod/nbttooltips)
and check the nbt of the item on client?
Server list shouldn't matter. Could you install some nbt viewer mod like this one (https://modrinth.com/mod/nbttooltips) and check the nbt of the item on client?
I'll do that later, but I figured out something else as well. It only happens in Creative Mode, once I switched to Survival, it restored itself to normal, and stayed that way after switching into Creative again. No idea what caused/causes it, as I now can't reproduce it anymore.
Try restarting the client. There is a chance it loaded because you tested on singleplayer
Try restarting the client. There is a chance it loaded because you tested on singleplayer
Yup, that did it, it still shows the broken text once directly going to Multiplayer, and Survival or Creative mode doesn't matter.
I'm installing the NBT Viewer now, I'll send you the output soon.
Alright here you go.
Client:
Server:
The NBT is clearly different, although not in a way that I can tell makes it not function. Also, after joining the server once having been in Singleplayer, the text loads correctly, but the NBT data stays the same.
OK. The server translation part is working (see the "fallback", which has correct text). Some client mod is breaking that by ignoring this part of text json, making translation not effect it.
OK. The server translation part is working (see the "fallback", which has correct text). Some client mod is breaking that by ignoring this part of text json, making translation not effect it.
No other mod has this issue, but if I'd guess as to which mod causes it, it would be Language Reload. I'll try without that one, I'll update you in a couple of minutes.
EDIT: Alright, it wasn't Language Reload either causing this. I had removed it, issue still persists.