At first I wasn't sure if it was a Quilt Loader quirk or not, but then I tested with Fabric too and the mod still doesn't work for anything but crates.

To demonstrate....

These are two different inventories filled by running the command /fish 64 repeatedly until my inventory was full. It is currently thundering and it is the first day of the world(a full moon), and as you can see I got a bunch or generic crates and even some Astral Crates(full moon exclusive!) but not a single fish that isn't vanilla. I should be getting special fish because of both the rain and the full moon - I remember playing this mod on 1.16 at some point and they were not this rare.

This also coincides with my experience fishing in survival worlds, where I was occasionally getting crates but never any of the fish, even if I should've been based on biome/event

Version of the mod tested:

Go Fish 1.5.0-1.18.2

Mod loaders tested(and have confirmed the issue ### on):

Quilt Loader 0.17.3/Quilted Fabric API beta 24 0.58.0
Fabric Loader 0.14.9/ Fabric Loader API 0.58.0

Same problems but in overworld only. In end and nether i am able to get custom fishes.
This is fixed in 1.19 version.

I fixed the problem. This repo doesnt accept pull request, so here is my fixed version : https://drive.google.com/file/d/1zNOF_Knmdci9--_k9cmQA5rmRmvhnMTM/view?usp=sharing

I fixed the problem. This repo doesnt accept pull request, so here is my fixed version : https://drive.google.com/file/d/1zNOF_Knmdci9--_k9cmQA5rmRmvhnMTM/view?usp=sharing

does this fix crate drops too? like soul valley one