Goblin Traders [Fabric]

Goblin Traders [Fabric]

6M Downloads

Smithing Table upgrades don't update base stats on goblin-modified armor

Fun-Ken opened this issue ยท 0 comments

commented

Describe the bug

Armor with goblin-modified attributes does not upgrade correctly in the smithing table. It retains the base attributes of the original item instead of adopting the attributes of the new, upgraded item.

Some mods (e.g., l_ender's Cataclysm, DragonLoot) allow players to upgrade netherite armor into a new tier (e.g., Ignitium/Cursium armor) using the smithing table. These new armors have better base stats (e.g., a netherite chestplate might have +8 armor, while the Ignitium version has +11).

If a goblin-modified netherite armor piece is used as the base for such an upgrade, the resulting Ignitium/Cursium armor will still have the base stats of the original netherite piece, not the improved stats of the new tier. However, enchantments and the extra goblin-applied modifiers are transferred correctly.

I did not test this with vanilla tools (e.g., Goblin modified diamond pickaxe -> netherite pickaxe).

To Reproduce

  1. Take a piece of armor that has been modified by a Goblin Trader
  2. Upgrade it in a smithing table into a new type of armor (added by a different mod) that has different base stats
  3. Observe that the base attributes of the new item have not changed, even though the item itself is different

Expected behavior

The armor base stats upgrade correctly.

Mod Version

1.11.2

Minecraft Version

1.21.1

Modloader

NeoForge

Crash Log (if applicable)

No response

Additional context

No response