Goety - The Dark Arts

Mod Loader

Forge-47.2.0

Mod version

goety-2.5.6.2

Issue description

ClassCastException when adding layer to PlayerRenderer

Goety-2/src/main/java/com/Polarice3/Goety/init/ClientInitEvents.java

Lines 112 to 119 in a9a5e73

    
           public static void addLayers(EntityRenderersEvent.AddLayers event){ 
        
               event.getSkins().forEach(renderer -> { 
        
                   PlayerRenderer playerRenderer = event.getSkin(renderer); 
        
                   if (playerRenderer != null) { 
        
                       addPlayerLayers(playerRenderer, event.getEntityModels()); 
        
                   } 
        
               }); 
        
           }

I am not sure why this works without a manual cast but the EntityRenderersEvent#AddLayers method gives you a LivingEntityRenderer<? extends Player, ? extends EntityModel<? extends Player>> which is not necessarily is of type PlayerRenderer. This will cause problems if mods want to render the player with a different renderer, like TeamLapen/Werewolves#177

Link or Post Log Files

https://paste.gg/p/anonymous/39e53399f8734c18a1722694ac4162ff

Steps to reproduce

No response

Additional information

No response

Thanks for letting me know! I'll see to fixing this!

Hopefully fixed in the latest updates!

	public static void addLayers(EntityRenderersEvent.AddLayers event){
	event.getSkins().forEach(renderer -> {
	PlayerRenderer playerRenderer = event.getSkin(renderer);
	if (playerRenderer != null) {
	addPlayerLayers(playerRenderer, event.getEntityModels());
	}
	});
	}