Gravestone mod - Graves

Gravestone mod - Graves

4M Downloads

Generate memorials freezing server

mattymaats opened this issue ยท 8 comments

commented

Hi Nightkosh,

I keep noticing this come up just before the whole server freezes and it happens on quite a regular basis.

In this report the player joined within loading distance of where a grave & memorial tried to generate which then froze the server the grave line is the last and then I have to manually force a restart on the server.
http://pastebin.com/5WtkVPVv

We're running GraveStone 2.9.7.jar with Cauldron 209 patch.

If you need any more information or the region file to take a look please let me know. I took a look at the region with MCedit and I couldn't see any chunk issues or even anything that had generated so I'm not sure if this it trying to regenerate in an area where it has an issue but the player had been in that location the previous night.

commented

Hmmm... It's looks like you were right, and there are some problems with graves.... But, is server freezing when someone died? In this case grave must be generated too...

As for this - disable catacombs generation too... You are alredy disable it, aren't you? But how it can be generated in your last log?

commented

Hi NightKosh,

The 2nd log is from another server of ours (a custom modpack one) which has the gravestone mod in it as well, I've only disabled B:GenerateSingleGraves=false on that server to test after the above issue happened so we could rule out if it was caused by one of the other generation options. The server is freezing when someone joins the server, so they've logged out in that location just fine but when they login it seems to freeze the main thread on the server.

commented

Hi NightKosh,

Just so you have some more info, the server is still freezing on the first server randomly when players join this is what the console shows. Basically the player joins then the main thread on the server completely freezes as everyone can still chat but the server is in a frozen state being unable to run any commands or break blocks etc, players can still move about and chat though.

25.11 18:28:40 [Server] INFO [18:28:40 INFO]: Ruins chunks logged: 31766
25.11 18:28:40 [Server] INFO [18:28:40 INFO]: Enhanced Portals is up-to-date :: v3.0.7
25.11 18:28:39 [Server] INFO [18:28:39 INFO]: Sent config to '_.'
25.11 18:28:39 [Server] INFO [18:28:39 INFO]: Player GCEntityPlayerMP['
'/25055, l='world', x=5760.26, y=72.99, z=1209.69](**** at 5760.255383080872,72.98938133108204,1209.6940528552007) connected. Sending ping
25.11 18:28:39 [Server] INFO [18:28:39 INFO]: com.advGenetics.Net.Packet.Packet3DNASync@40b65417
25.11 18:28:39 [18:28:39 INFO]: ***_ ran command Message of the Day
25.11 18:28:39 [Connect] User [18:28:39 INFO]: ***, IP ***
25.11 18:28:39 [Server] INFO [18:28:39 INFO]: [Server thread] Server side modded connection established
25.11 18:28:37 [Server] INFO [18:28:37 INFO]: Attempting connection with missing mods [DeathCounter, Morpheus] at CLIENT
25.11 18:28:37 [Server] INFO [18:28:37 INFO]: Client attempting to join with 191 mods : [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],Growthcraft|[email protected],[email protected],[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],[email protected],[email protected],[email protected],WR-CBE|[email protected],UniversalElectricity@@major@.@minor@.@revis@,[email protected],NEIAddons|[email protected],[email protected],NEIAddons|[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],ProjRed|[email protected],[email protected],[email protected],[email protected],[email protected],appliedenergistics2-core@rv1-stable-1,[email protected],[email protected],[email protected],ProjRed|[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],ProjRed|[email protected],[email protected],Growthcraft|[email protected],MineFactoryReloaded|[email protected],MineFactoryReloaded|[email protected],ResonantEngine@@major@.@minor@.@revis@,[email protected],[email protected],[email protected],[email protected],TooMuchRain@%VERSION%,MineFactoryReloaded|[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],MineFactoryReloaded|[email protected],[email protected],BuildCraft|[email protected],[email protected],MFFS@@major@.@minor@.@revis@,[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],[email protected],MineFactoryReloaded|[email protected],[email protected],[email protected],[email protected],ProjRed|[email protected],[email protected],SSR@Alpha 1.2,[email protected],BuildCraft|[email protected],Growthcraft|[email protected],[email protected],MineFactoryReloaded|[email protected],TubesCore@${version},[email protected],[email protected],[email protected],BuildCraft|[email protected],[email protected],[email protected],[email protected],NEIAddons|[email protected],Micdoodlecore@,[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],@000,appliedenergistics2@rv1-stable-1,MineFactoryReloaded|[email protected],Growthcraft|[email protected],ProjRed|[email protected],MineFactoryReloaded|[email protected],BuildCraft|[email protected],[email protected],[email protected],HardcoreQuesting@The Journey (4.2.1),[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],Growthcraft|[email protected],ProjRed|[email protected],ProjRed|[email protected],[email protected] v1.7.1,[email protected],Eln@43,StevesFactoryManager@A93,[email protected],[email protected],[email protected],[email protected],BuildCraft|[email protected],MineFactoryReloaded|[email protected],[email protected],[email protected],[email protected],ProjRed|[email protected],[email protected],BuildCraft|[email protected],[email protected],NEIAddons|[email protected],[email protected],[email protected],MineFactoryReloaded|[email protected],[email protected],Growthcraft|[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],WR-CBE|[email protected],OpenModsCore@@Version@,[email protected],[email protected],[email protected],Growthcraft|[email protected],[email protected],[email protected],Growthcraft|[email protected],[email protected],[email protected],[email protected],[email protected],WR-CBE|[email protected]
25.11 18:28:37 [Server] INFO [18:28:37 INFO]: Client protocol version 1
25.11 18:28:37 [Server] INFO [18:28:37 INFO]: UUID of player **** is ******

commented

Edit: Please disregard this comment as I see this issue was fixed in commit bf85a34

I'm having the server freeze on catacombs generation, 100% CPU. After 10 minutes the server had still not responded.
gravestonemod

I have dumped a stack trace so you can see where the generation is going into an infinite loop.

"Server thread" #19 prio=5 os_prio=0 tid=0x00007f73cca0a800 nid=0x550a runnable [0x00007f73837c1000]
  java.lang.Thread.State: RUNNABLE
    at gravestone.structures.catacombs.components.Fence.createEntrance(Fence.java:170)
    at gravestone.structures.catacombs.components.Fence.addComponentParts(Fence.java:37)
    at gravestone.structures.catacombs.CatacombsSurface.build(CatacombsSurface.java:126)
    at gravestone.structures.catacombs.CatacombsSurface.<init>(CatacombsSurface.java:29)
    at gravestone.structures.catacombs.CatacombsGenerator.generate(CatacombsGenerator.java:47)
    at gravestone.structures.GraveStoneWorldGenerator.generateSurface(GraveStoneWorldGenerator.java:35)
    at gravestone.structures.GraveStoneWorldGenerator.generate(GraveStoneWorldGenerator.java:28)
    at cpw.mods.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:106)
    at net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:280)
    at net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1040)
    at net.minecraft.world.gen.ChunkProviderServer.originalLoadChunk(ChunkProviderServer.java:190)
    at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:131)
    at net.minecraft.world.gen.ChunkProviderServer.func_73158_c(ChunkProviderServer.java:101)
    at net.minecraft.world.gen.ChunkProviderServer.func_73154_d(ChunkProviderServer.java:199)
    at net.minecraft.world.World.func_72964_e(World.java:419)
    at net.minecraft.world.World.func_147439_a(World.java:345)
    at net.minecraft.world.World.func_147437_c(World.java:365)
    at mods.natura.worldgen.BaseCropWorldgen.generateBarley(BaseCropWorldgen.java:147)
    at mods.natura.worldgen.BaseCropWorldgen.generate(BaseCropWorldgen.java:46)
    at cpw.mods.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:106)
    at net.minecraft.world.gen.ChunkProviderServer.func_73153_a(ChunkProviderServer.java:280)
    at net.minecraft.world.chunk.Chunk.func_76624_a(Chunk.java:1045)
    at net.minecraft.world.gen.ChunkProviderServer.originalLoadChunk(ChunkProviderServer.java:190)
    at net.minecraft.world.gen.ChunkProviderServer.loadChunk(ChunkProviderServer.java:131)
    at net.minecraft.world.gen.ChunkProviderServer.func_73158_c(ChunkProviderServer.java:101)
    at net.minecraft.world.gen.ChunkProviderServer.func_73154_d(ChunkProviderServer.java:199)
    at net.minecraft.world.World.func_72964_e(World.java:419)
    at net.minecraft.world.World.func_147439_a(World.java:345)
    at net.minecraft.block.BlockGrass.func_149674_a(BlockGrass.java:57)
    at net.minecraft.world.WorldServer.func_147456_g(WorldServer.java:391)
    at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:183)
    at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:625)
    at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:334)
    at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:547)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:427)
    at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:685)
commented

Hi Nightkosh,

This keeps happening on the server with the below spam in the console causing a lot of lag then the server completely freezes, is there something you could suggest for me to be able to gather more information for you as this is totally freezing up the server. After the last message from a user the server completely freezes (times out everyone on the server) the start command is a feature I have to run at certain times but due to the server being frozen it shows it as already running and I have to manually restart the server.

14.11 15:32:12 [Multicraft] Stopping server!
14.11 15:30:00 [Multicraft] Server ran command Save World
14.11 15:30:00 [Multicraft] Server ran command Start
14.11 15:30:00 [Multicraft] Server already running
14.11 15:20:00 [Multicraft] Server ran command Start
14.11 15:20:00 [Multicraft] Server already running
14.11 15:19:46 [Server] INFO [15:19:46 INFO]: ****: lag plz
14.11 15:19:27 [Server] INFO [15:19:27 INFO]: Generate grave at 6023x1047
14.11 15:19:24 [Server] INFO [15:19:24 INFO]: Generate grave at 5895x1047
14.11 15:19:20 [Server] INFO [15:19:20 INFO]: ***
* left the game.
14.11 15:19:20 [Disconnect] User [15:19:20 INFO]: ***** has disconnected, reason: Timed out
14.11 15:19:19 [Server] INFO [15:19:19 INFO]: Generate grave at 6039x1143
14.11 15:19:14 [Server] INFO [15:19:14 INFO]: Generate grave at 6007x1367
14.11 15:19:08 [Server] INFO [15:19:08 INFO]: Generate grave at 5991x1255
14.11 15:19:03 [Server] INFO [15:19:03 INFO]: Generate grave at 5879x1175
14.11 15:19:03 [Server] INFO [15:19:03 INFO]: Generate grave at 5751x1175
14.11 15:18:31 [Server] INFO [15:18:31 INFO]: Generate memorial at 5910x1270
14.11 15:18:16 [Server] INFO [15:18:16 INFO]: Generate grave at 5863x1319
14.11 15:17:07 [Server] INFO [15:17:07 INFO]: [ClearLag] Removed 246 Entities!

commented

Hm.. try to disable graves generation(only graves which generates at world generation) - set "GenerateSingleGraves" to "false". If you are right, and there are some problems with graves it will help(as a temporary fix). Also post please a list of mods used on your server.

commented

Hi NightKosh,

I've changed it to the below settings, could you confirm this is ok and I presume it will still generate playergraves on death. It seems to have helped but we're still experiencing some server freezes from something else as well but I can't seem to pinpoint what's causing it after a player logs on the server.

general {
B:CanPlaceGravesEveryWhere=false
B:EnableBossSpawnerCraftingRecipe=false
B:EnableCreeperStatuesRecipes=false
B:EnableForestryBackpacks=true
B:EnableMonsterSpawnerCraftingRecipe=false
B:EnableNightStone=true
B:EnableThunderStone=true
B:GenerateCatacombs=false
B:GenerateCemeteries=false
B:GenerateGravesInLava=true
B:GenerateMemorials=false
B:GeneratePetGraves=false
B:GeneratePlayerGraves=true
B:GenerateSingleGraves=false
B:GenerateSwordGraves=false
B:GenerateUndertaker=true
B:GenerateVillageMemorials=false
B:GenerateVillagerGraves=false
I:MaximumCatacombsGenerationHeight=75
B:RemoveEmptyGraves=false
B:ReplaceHauntedChest=false.

Are you sure you want the mod list? It's a pretty hefty one lol, probably the best way would be to see the modpack site which this is for. If you want an actual list let me know and I'll put it together for you but I'm not the pack creator and they're a pain to actually put in any fixes currently. We do use GSM on our own custom pack as well so hopefully it's one we can reflect on that.

http://www.atlauncher.com/pack/HermitcraftModsauce

Thanks for taking the time to get back to me as well.

commented

Hi NightKosh,

Just so you know on our custom server which has a lot of different mods this also froze the server today and it freezes every time the player logs into that location now.

17.11 23:00:00 [Multicraft] Server ran command Save World
17.11 22:56:30 [Server] INFO [22:56:30 INFO]: Catacombs generation - End Checking area height
17.11 22:56:30 [Server] INFO [22:56:30 INFO]: Catacombs generation - Begin Checking area height
17.11 22:56:30 [Server] INFO [22:56:30 INFO]: Catacombs generation - End Checking area for another catacombs or villages
17.11 22:56:30 [Server] INFO [22:56:30 INFO]: Catacombs generation - Begin Checking area for another catacombs or villages
17.11 22:56:28 [Server] INFO [22:56:28 INFO]: Generate grave at 1191x-953
17.11 22:56:23 [Server] INFO [22:56:23 INFO]: Generate grave at 1063x-953
17.11 22:56:22 [Server] INFO [22:56:22 INFO]: Generate grave at 903x-953
17.11 22:56:13 [Server] INFO [22:56:13 INFO]: Generate grave at 935x-857
17.11 22:56:08 [Server] INFO [22:56:08 INFO]: Generate grave at 1031x-857
17.11 22:56:08 [Server] INFO [22:56:08 INFO]: Generate memorial at 902x-826

Link to mods included on our custom pack - http://i59.tinypic.com/qqz5ep.jpg

I've disabled only B:GenerateSingleGraves=false on our custom pack to check if this is the issue.