Bug description

Now, I did read the warning about not asking questions or making requests, however...

1. Comments are disabled
2. If you have a discord, I cannot find it
3. Unlike other Githubs, you do not have a request form in the issues section, just bugs and translations
4. I can find no other way to contact you

All that being the case, I find that I must ask you a question: How exactly do you expect people to ask you questions or give you suggestions (I did not, after all, notice any prohibitions against doing so anywhere...)?!?

Since I am left with no other option, we will both just have to be dissatisfied with this misappropriation of a bug report. At least it is within the power of one of us to fix this less than idea circumstance, and that's not me, so complaining to me about this would just be a waste of both of our time.

From the website description, I can see that you struggled with the grave site edge case when super high up. I would like to propose a solution! If the player is above build height, rather than dropping their items, they should get a grave built right at the build height limit, just like they get when falling into the void. For edge cases where there is no open block clear up to build height (or they die above build height and the top most build height layer is full), then the gravestone should replace the build height block, which gets stored (along with all its NBT and other data) inside the grave. If there's already a block just below build height, then that should be used as the base of the grave, rather than a dirt block, but if there isn't, then, and only then, a dirt block could get placed for the gravestone to rest upon.

Upon breaking the gravestone (with or without silk touch), the block that the gravestone replaces should be put back exactly as it was before. To be clear, while the block is 'technically' inside the gravestone, it's not visible to the player if they open the gravestone up, and is not accessible by any means other than breaking the gravestone and putting the block back exactly where it was before. This should fix any problems with the gravestone replacing a block and also allow one to always get a gravestone on death, rather than not getting one under the two current edge case limits that currently exist.

True, technically certain modded multi-block machines would be, at least temporarily, broken by the gravestone taking out one of their needed multi-blocks, but no mod structures/multi-block machines spawn naturally at the build height limit that would be broken by this action, so it is simply the responsibility of the player using this mod to either not build one at the build height limit, or be aware of the consequences of doing so while also using this mod. Either way, such consequences would likely be less bad than not getting a gravestone upon death, and if they are, an config option to turn off this edge case and go back to the old one could be provided.

Minecraft version

1.20.1

Mod version

1.20.1-1.0.24

Mod loader and version

Forge 47.4.0

Steps to reproduce

1. Fly Above Build Height
2. Die
3. Don't Get A Gravestone

Expected behavior

1. Fly Above Build Height
2. Die
3. Get A Gravestone

Log files

https://gist.github.com/

Screenshots

No response

Having the grave replace a block could cause issues for redstone contraptions or multiblock structures. This mod should be as non destructive as possible. If this rare case would really happen theres still the restore command that could be used. So you can never truly lose all your items.

I recognize that, but that is such an extreme and rare edge case that I think adding a config option to turn it of ought to suffice. Besides which, needing to run a command both requires cheats to be on, and feels like and admission of failure, to me at least. I ought to be able to play my game without 'cheating' or out outside of normal game play to use a computer commands to tell the game what to do. Everything should work as I need it to from within the game.

But if you really don't like that, then why not just search for the nearest build height limit block space that isn't occupied? Sure, that would be more computationally complex, but you'd only be searching a single y layer, and if there isn't a block available among the loaded chunks, you could just not place the grave until the player moved over there and chunks start getting loaded, then place the grave in the first fitting block space as the newest chunk is being loaded. To the player it would look the same, and it would satisfy your "absolutely no destruction" policy. It would also be vary tedious for the player, but from my perspective I'd at least know that the tedium I'm suffering from is the direct result of my own actions and decisions, and can be resolved in game without cheating with a command...

Oh, and I will say that the fact that I can use a command to restore is one of the reasons why I like this death mod, because sometimes things do go out of whack and the game bugs out on me, and if I loose my stuff to game glitches beyond my control, I like knowing that I can ALWAYS get my stuff back. Under those circumstances, using a command doesn't feel like cheating because I'm basically fighting a code bug, and that does feel like a situation where using a command to tell the game what it's supposed to be doing - instead of what it is doing - is right and reasonable.

Yeah I think having it as a config option is a good idea

Awesome, thanks!!! Oh, and I did fill this out in the “bug report”, but I really need this for the 1.20.1 forge version, though I would appreciate it being in all the 1.21 NeoForge versions even more, as I hope to move to there as soon as my final holdout mods are updated!

Thank you so very much!!! I REALLY appreciate this!!! Awesome mod!!!