'your high favor earned you blessing from...' spam
kubistonek opened this issue ยท 3 comments
the 'your high favor earned you blessing from...' message keeps appearing every ~30 minutes for no reason
Yes... that's because a favor effect was triggered on the player. The message is not spam, it's there so you know why you suddenly have a potion effect or an extra emerald or something.
I'm inclined to believe this might actually be an issue - I have also been getting this message CONSTANTLY like clockwork on a dedicated server. It's only ever with Hades even if I have high favor with other deities(in this case, Hera or Hermes).
The reason I think this is a bug rather than intended behavior is because I never seem actually get any in-game effects accompanying the chat messages; certainly none of the things that seem detailed in the data files of the mod, going by the source. No items, no summoned entities, no potion effects. It's possible that there is an effect being triggered every single time that is simply not immediately obvious, but I find it difficult to believe that with me carefully checking both my inventory and surroundings every time I get the message.
It is worth mentioning that I am running a slightly older version of the mod - 16.4.15 - because of the unregistered nemean lion den feature issue and me not wanting to compromise other mod worldgen while waiting for a fix - but unless this behavior was specifically addressed with the newer version's data pack format changes, it probably still happens on 16.4.16 as well.
This next bit is a suggestion that is directly relevant to this:
- Have the message that's sent to player because of a favor effect hint at what the favor effect was rather than a generic "deity did something because of high/low favor" message, like "Hades has blessed you with [item name] as thanks for your actions" or "Hades incurs his wrath against you, summoning [monster name]", etc. It would both make it easier to troubleshoot deity favor effects and provide more clarity for what it's actually doing for the player.
Alternatively, maybe have a config option so players can choose whether they want this message in their chat or above their hotbar as a toast(similar to bed sleeping eligibility messages). This would allow the player to still see a message about it while they're playing, but it wouldn't fill up the chat.
EDIT: I looked more carefully at the favor levels and values for each deity after I posted this - and I shouldn't have been able to get favor effects from any of the three deities I mentioned, given what my favor levels were at; none were ever high enough for them. So I'm reasonably sure that whatever has been going on with the favor messages and Hades were probably not actual favor effect indications.