GregTech Classic

GregTech Classic

25k Downloads

Tiny Code improvements.

Speiger opened this issue ยท 3 comments

commented

https://github.com/e99999/GT-Classic/blob/master/src/main/java/gtclassic/blocks/resources/GTBlockOre.java#L60
Could be moved into the Enum Instead since its not a "Dynamic Drop".

https://github.com/e99999/GT-Classic/blob/master/src/main/java/gtclassic/blocks/machines/lv/GTBlockAlloySmelter.java#L16
Should extends BlockMultiID because extending the current class might break things if i change stuff in the core.

https://github.com/e99999/GT-Classic/blob/master/src/main/java/gtclassic/items/tools/GTItemAdvancedChainsaw.java#L43
That thing wont work because it is a reference to the AudioManagerClient (line 504) which is adding a tracker for entities that could have chainsaws in their hand. You need to write a tracker for there to play the audiosource track.

I hope thats some information how to improve things ^^"

commented

all fixed

commented

https://github.com/e99999/GT-Classic/blob/master/src/main/java/gtclassic/GTClassicTextureLoaderHelper.java#L9

No longer needed there is now a Event for that in IC2Icons if you look it up thats now useable.

commented

https://github.com/e99999/GT-Classic/blob/master/src/main/java/gtclassic/world/GTOreGen.java#L85
Look up in worldgen mineable how its "default" predicate is because ores can also generate in none "Stone" blocks that are still "StoneTypes"