GregTech Food Option

GregTech Food Option

112k Downloads

[Bug] Crash/softlock when other player eats food from Gregtech Food Option

Vapaman opened this issue ยท 8 comments

commented

Step to reproduce:

  1. Join multiplayer game
  2. Eat food from GTFO, like bacon
  3. ...
  4. Profit! (you just crashed the others game)

Mod list:
.mixinbooter-4.1
AIImprovements-1.12-0.0.1b3
AppleSkin-mc1.12-1.0.14
appliedenergistics2-rv6-stable-7-extended_life-v50
AquaAcrobatics-1.11.2
Clumps-3.1.2
CodeChickenLib-1.12.2-3.2.3.358-universal
Controlling-3.0.10
CraftTweaker2-1.12-4.1.20.674
CTM-MC1.12.2-1.0.2.31
EnderCore-1.12.2-0.5.76
EnderIO-base-1.12.2-5.3.70
EnderIO-conduits-1.12.2-5.3.70
EnderIO-conduits-appliedenergistics-1.12.2-5.3.70
EnderIO-integration-forestry-1.12.2-5.3.70
foamfix-0.10.14-1.12.2
forestry_1.12.2-5.8.2.422
gravestone-1.10.3
GregicalityMultiblocks-1.12.2-1.1.0
Gregification-1.12.2-0.0.1 (PR #18 autobuild)
GregTech Food Option-1.12.2-1.2.1
gregtech-1.12.2-2.1.1-beta
Hwyla-1.8.26-B41_1.12.2
InventoryTweaks-1.64+dev.151
jei_1.12.2-4.16.1.302
jeibees-0.9.0.5-mc1.12.2
jeiintegration_1.12.2-1.6.0
journeymap-1.12.2-5.7.1
Mantle-1.12-1.3.3.55
moreoverlays-1.15.1-mc1.12.2
Morpheus-1.12.2-3.5.106
MouseTweaks-2.10.1-mc1.12.2
NuclearCraft-2o.5.5-1.12.2
Patchouli-1.0-23.6
QMD-1.1-beta4-1.12.2
stg-1.12.2-1.2.3
Trinity-1.4.b
UniDict-1.12.2-3.0.10
WanionLib-1.12.2-2.9

I cannot reproduce it with just GTFO and its dependants, seems to be a conflict, most likely with MixinBooter or AquaAcrobatics.

commented

Did you fix the issue? It sounds very plausible.

commented

This seems to be a bug with Aqua Arcobatics, please ignore this issue.

commented

I mean, I do want to make sure that my mod doesn't mess with it. Also, it probably is a bug with GregTech Food Option, given how you described the problem.

commented

It happens with vanilla foods as well, so its more likely a bug with aqua aerobatics with its eating animation

commented

The main question is if removing GTFO or AA changes things. Can you test this with just GTFO and without AA?

commented

I'll test, just a moment.

commented

I do know what the issue is, though, and I could fix it on this side; what I do in GTFO for some food items is to set the duration it takes to eat a certain item, so as to provide another point of "balance". Because Mojang is dumb, when the animation tries to run for longer than the game expects (as I would in GTFO), the animation doesn't play correctly, so I override certain parts of it. It is likely that AA then handles the animation itself too, which then leads to your crash. In the future, I should probably make this more compatible with other mods such as AA.

commented

Yep, it doesn't crash with AA animation turned off, moving this issue to their issue tracker.