Gregtech++ [GT++] [GTplusplus]

Gregtech++ [GT++] [GTplusplus]

94.1k Downloads

dust items don't render OVERLAY layer

leagris opened this issue · 5 comments

commented

Dust items don't render the _OVERLAY layer

GT++ dust, dustSmal and dustTiny does not render the dust overlays.
Possibly other items affected.
Issue is followup of #188

Provide a general summary of the issue in the Title above,
Something descriptive and related to the issue + Mod Version in [].
Example Custom GT++ Alveary Frame Blocks do not work [v1.5.0-alpha]

Expected Behavior

Render dusts with OVERLAY like Gregtech does:
image

Current Behavior

dustMaterial, dustSmalMaterial, dustTinyMaterial don't render their _OVERLAY
Similar issue as #188 but with dusts

  • assets/gregtech/textures/items/materialicons/METALLIC/dust.png
    dust
  • assets/gregtech/textures/items/materialicons/METALLIC/dust_OVERLAY.png
    dust_OVERLAY

⇒ GT++ only renders the first dust.png layer
image

Game Environment

Include as many relevant details about the game environment or modpack you experienced the bug in/on.
If you are using a Modpack:

  • Modpack Name: BeyondREality
  • Version used: DEV

Also include:

  • Gregtech version: 5.09.31
  • IC2 version: 2-2.2.828-experimental
  • Java version: OpenJDK Runtime Environment (build 1.8.0_232-ea-8u232-b09-0ubuntu1-b09)
  • Operating System: Linux

Misc Info

Check all that apply ([ ] -> [x] - use a lowercase x)

  •    Using GT:NH/GT:New Horizons?
  •    Single Player?
  •    Multi Player?
commented

Actually, this is false and was fixed in #188 when you originally reported it. Some special use, non-autogenerated dusts do NOT use the overlay and that's due to their base class. 98% can and do show it fine.

https://github.com/alkcorp/GTplusplus/blob/DevTop/src/Java/gtPlusPlus/core/item/base/BaseItemComponent.java#L476

	@Override
	public IIcon getIconFromDamageForRenderPass(final int damage, final int pass) {
		if (CORE.ConfigSwitches.useGregtechTextures) {
			if(pass == 0) {
				return this.base;
			}
			return this.overlay;			
		}
		return this.base;
	}

	@Override
	public void registerIcons(final IIconRegister i) {

		if (CORE.ConfigSwitches.useGregtechTextures){
			this.base = i.registerIcon(getCorrectTextures());
			this.overlay = i.registerIcon(getCorrectTextures() + "_OVERLAY");
		}
		else {
			this.base = i.registerIcon(getCorrectTextures());
			//this.overlay = i.registerIcon(getCorrectTextures() + "_OVERLAY");
		}
	}
commented

Well, it is not fixed in the GT-PlusPlus-1.7.02.09.jar I got from Curse.

commented

@leagris login with your github account and link it.

commented

@Dream-Master How to access artifacts?