[Bug] Titanium pipes, rotors and machine casing produce engine intake casing on crafting table, but produce extreme engine intake casing in assembler

Question

[Bug] Titanium pipes, rotors and machine casing produce engine intake casing on crafting table, but produce extreme engine intake casing in assembler

chemlzh opened this issue 9 months ago · 2 comments

chemlzh commented 9 months ago

Checked for existing issues

I have checked for existing issues, and have found none.

Tested latest version

I have checked that this occurs on the latest version.

GregTech CEu Version

v1.2.0.a, but may have been existed at least v1.1.3 or v1.1.4

Recipe Viewer Installed

EMI

Environment

Singleplayer

Cross-Mod Interaction

No

Other Installed Mods

No. Only pure GTCEuM installed

Expected Behavior

Engine intake casing can be crafted on crafting table using 1 enhanced machine casing (made of titanium), 2 titanium rotors and 4 titanium normal fluid pipes. If we put these spare parts in the assembler, we will also get 2 engine intake casings.

Actual Behavior

Put titanium spare parts mentioned above in the assembler will get 2 extreme engine intake casings (made of tungstensteel).

Steps to Reproduce

Prepare 1 enhanced machine casing (made of titanium), 2 titanium rotors and 4 titanium normal fluid pipes;
Put all of them in the assembler, and wait for assembly process.
Take out the final product.

Additional Information

This is the recipe implemented on crafting table, with correct products.

This is the recipe implemented on assembler, with incorrect products.

Similar recipe error occurs in titanium cell recycling. (See #1068) Therefore I doubt some recipes using titanium spare parts would also have bugs. Please fix it ASAP.

chemlzh · Answer 1 · 2024-04-29T07:58:52.000Z

I have found the bug in AssemblerRecipeLoader.java

        ASSEMBLER_RECIPES.recipeBuilder("stable_titanium_casing")
                .inputItems(rotor, Titanium, 2)
                .inputItems(pipeNormalFluid, Titanium, 4)
                .inputItems(CASING_TITANIUM_STABLE.asStack())
                .outputItems(CASING_EXTREME_ENGINE_INTAKE.asStack(ConfigHolder.INSTANCE.recipes.casingsPerCraft))
                .duration(50).EUt(16).save(provider);

"CASING_EXTREME_ENGINE_INTAKE" in code above should be "CASING_ENGINE_INTAKE".

Similar to #1068, I cannot fix the bug since I don't have the permission even if I fork the code. Maybe you can fix it. @screret

chemlzh · Answer 2 · 2024-04-29T08:12:59.000Z

I have found the bug in AssemblerRecipeLoader.java
        ASSEMBLER_RECIPES.recipeBuilder("stable_titanium_casing")
                .inputItems(rotor, Titanium, 2)
                .inputItems(pipeNormalFluid, Titanium, 4)
                .inputItems(CASING_TITANIUM_STABLE.asStack())
                .outputItems(CASING_EXTREME_ENGINE_INTAKE.asStack(ConfigHolder.INSTANCE.recipes.casingsPerCraft))
                .duration(50).EUt(16).save(provider);
"CASING_EXTREME_ENGINE_INTAKE" in code above should be "CASING_ENGINE_INTAKE".

Similar to #1068, I cannot fix the bug since I don't have the permission even if I fork the code. Maybe you can fix it. @screret

I figure it out why I cannot edit, since I used to try edit my code in the browser. Now I have fixed the bug, and it just need code review. Thanks again! @screret

Share to