Crash on AddPackFindersEvent event with Structurify

Question

Crash on AddPackFindersEvent event with Structurify

Faboslav opened this issue 5 months ago · 20 comments

Faboslav commented 5 months ago

Checked for existing issues

I have checked for existing issues, and have found none.

Tested latest version

I have checked that this occurs on the latest version.

GregTech CEu Version

1.4.0

Minecraft Version

1.21:1

Recipe Viewer Installed

No Recipe Viewer

Environment

SP

Cross-Mod Interaction

No

Other Installed Mods

latest.log

Expected Behavior

Mod should not throw error during the AddPackFindersEvent neo forge event

Actual Behavior

Mod throws the error

Steps to Reproduce

Install structurify open the mod menu and open any section for configuration

Additional Information

No response

Faboslav · Answer 1 · 2024-09-01T18:30:24.000Z

It's also possible that some kind of update will be needed on both sides, but it would be great, if you can check why the AddPackFindersEvent fails.

screret · Answer 2 · 2024-09-01T18:38:13.000Z

wtf do you mean the Zero Point Module "isn't a battery" :wuh:

Faboslav · Answer 3 · 2024-09-01T18:48:39.000Z

Yeah, maybe to get you up to speed with my mod, at some point, currently in the:

	private static void onCommonSetup(FMLCommonSetupEvent event) {
		event.enqueueWork(() -> {
			LoadConfigEvent.EVENT.invoke(new LoadConfigEvent());
		});
	}

I am basically triggering logic which is run when you go into the create world screen, so i load the datapacks and create access to registries then i store some data based on the loaded registries, but i should not be doing anything shady. But since literally no one did anything similiar to this, i have no reference :D, maybe i just need to find better spot to doing this logic, since apparently with the 1.0.2 version of my mod it somehow worked along with yours, but other stuff broke.

Update: 1.0.2 version of my mod broke something in Placebo mod, which disconnected the player when joining the world due to weird packet.

screret · Answer 4 · 2024-09-01T19:50:40.000Z

there might've been some error earlier in the loading, as that (not a real MC registry btw) should've been unfrozen before we add any entries to it.

Faboslav · Answer 5 · 2024-09-01T19:48:34.000Z

Okay, with more proper place, now i am having this:

[21:06:57] [Render thread/ERROR] [structurify/]: Failed to load registry manager.
java.util.concurrent.ExecutionException: java.lang.ExceptionInInitializerError
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396) ~[?:?] {}
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073) ~[?:?] {}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.registry.StructurifyRegistryManagerProvider.reloadRegistryManager(StructurifyRegistryManagerProvider.java:62) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.config.data.WorldgenDataProvider.reload(WorldgenDataProvider.java:49) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.config.StructurifyConfig.load(StructurifyConfig.java:56) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:mixin,re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.Structurify.loadConfig(Structurify.java:80) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:mixin,re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.events.base.EventHandler.invoke(EventHandler.java:33) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.neoforge.StructurifyNeoForge.lambda$onIdkk$2(StructurifyNeoForge.java:55) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.DeferredWorkQueue.lambda$makeRunnable$2(DeferredWorkQueue.java:67) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.DeferredWorkQueue.makeRunnable(DeferredWorkQueue.java:62) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.DeferredWorkQueue.lambda$runTasks$0(DeferredWorkQueue.java:47) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at java.base/java.util.concurrent.ConcurrentLinkedDeque.forEach(ConcurrentLinkedDeque.java:1650) ~[?:?] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.DeferredWorkQueue.runTasks(DeferredWorkQueue.java:47) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimpleReloadInstance.lambda$new$3(SimpleReloadInstance.java:69) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:148) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,re:computing_frames,re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:111) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.runTick(Minecraft.java:1155) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:configuration.mixins.json:MinecraftMixin from mod configuration,pl:mixin:APP:globalpacks.mixins.json:MinecraftMixin from mod globalpacks,pl:mixin:APP:yacl.mixins.json:MinecraftMixin from mod yet_another_config_lib_v3,pl:mixin:A,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.run(Minecraft.java:807) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:configuration.mixins.json:MinecraftMixin from mod configuration,pl:mixin:APP:globalpacks.mixins.json:MinecraftMixin from mod globalpacks,pl:mixin:APP:yacl.mixins.json:MinecraftMixin from mod yet_another_config_lib_v3,pl:mixin:A,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.main.Main.main(Main.java:230) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?] {}
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:136) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:124) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonClientLaunchHandler.runService(CommonClientLaunchHandler.java:32) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.lambda$launchService$4(CommonLaunchHandler.java:118) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:103) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:74) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-11.0.4.jar%23149!/:?] {}
	at cpw.mods.bootstraplauncher@2.0.2/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:210) [bootstraplauncher-2.0.2.jar:?] {}
	at cpw.mods.bootstraplauncher@2.0.2/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69) [bootstraplauncher-2.0.2.jar:?] {}
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?] {}
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?] {}
	at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:67) [ForgeWrapper-prism-2024-02-29.jar:prism-2024-02-29] {}
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100) [NewLaunch.jar:?] {}
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) [NewLaunch.jar:?] {}
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) [NewLaunch.jar:?] {}
Caused by: java.lang.ExceptionInInitializerError
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.loader.GTOreLoader.apply(GTOreLoader.java:53) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.loader.GTOreLoader.apply(GTOreLoader.java:33) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimplePreparableReloadListener.lambda$reload$1(SimplePreparableReloadListener.java:19) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?] {}
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?] {}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimpleReloadInstance.lambda$new$3(SimpleReloadInstance.java:69) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.Util.blockUntilDone(Util.java:872) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at TRANSFORMER/[email protected]/net.minecraft.Util.blockUntilDone(Util.java:861) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.registry.StructurifyRegistryManagerProvider.reloadRegistryManager(StructurifyRegistryManagerProvider.java:48) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	... 41 more
Caused by: java.lang.IllegalStateException: [register] registry gtceu:ore_vein has been frozen
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.api.registry.GTRegistry.registerOrOverride(GTRegistry.java:117) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.api.worldgen.GTOreDefinition.register(GTOreDefinition.java:147) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.worldgen.GTOres.create(GTOres.java:744) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.worldgen.GTOres.create(GTOres.java:737) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.worldgen.GTOres.<clinit>(GTOres.java:63) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.loader.GTOreLoader.apply(GTOreLoader.java:53) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.loader.GTOreLoader.apply(GTOreLoader.java:33) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimplePreparableReloadListener.lambda$reload$1(SimplePreparableReloadListener.java:19) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?] {}
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?] {}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimpleReloadInstance.lambda$new$3(SimpleReloadInstance.java:69) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.Util.blockUntilDone(Util.java:872) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at TRANSFORMER/[email protected]/net.minecraft.Util.blockUntilDone(Util.java:861) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.registry.StructurifyRegistryManagerProvider.reloadRegistryManager(StructurifyRegistryManagerProvider.java:48) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	... 41 more

But since WorldStem.registries returns LayeredRegistryAccess<RegistryLayer> registries, which are already immutable by default, i dont understand why it tries to register new entries

Faboslav · Answer 6 · 2024-09-01T19:52:20.000Z

Yeah, i get my registry access from this: https://github.com/Faboslav/structurify/blob/master/common/src/main/java/com/faboslav/structurify/common/registry/StructurifyRegistryManagerProvider.java

Which always returns frozen registries, so i am not sure, why there is any kind of hook on that :/.

Faboslav · Answer 7 · 2024-09-01T19:53:37.000Z

Or more like i know what is the connection, but i dont know why it tries to register the stuff after the registries are frozen here.

screret · Answer 8 · 2024-09-01T19:53:44.000Z

wait why do you load registries when loading your config??

screret · Answer 9 · 2024-09-01T19:54:16.000Z

Or more like i know what is the connection, but i dont know why it tries to register the stuff after the registries are frozen here.

it's a reload listener. it loads everything every time a reload happens, which you're causing here.

Faboslav · Answer 10 · 2024-09-01T19:55:11.000Z

Yeah, but it should not try to register stuff into frozen registries, i have zero control over state of the registries, i am just simply calling part of minecraft core code.

Faboslav · Answer 11 · 2024-09-01T19:55:51.000Z

I need to load bunch of worldgen stuff from registries to generate my config values, which is the whole purpose of my mod

screret · Answer 12 · 2024-09-01T19:55:57.000Z

yeah, but as I said, the "registries" that the worldgen data is loaded into is actually just a map wrapper. it's not a Registry instance at all

Faboslav · Answer 13 · 2024-09-01T19:56:24.000Z

Then what are my options here?

screret · Answer 14 · 2024-09-01T19:58:07.000Z

this crashlog doesn't match the code on your git

Faboslav · Answer 15 · 2024-09-01T19:59:23.000Z

I know that i am doing something pretty unexpected from mod, but in the end i am triggering the "create world menu" logic, just earlier, also i tried this mod on modpack with 460 mods and it all worked, so i have zero idea, what is wrong in this case.

Which part doesnt match?

Faboslav · Answer 16 · 2024-09-01T20:01:42.000Z

Okay, with more proper place, now i am having this:

[21:06:57] [Render thread/ERROR] [structurify/]: Failed to load registry manager.
java.util.concurrent.ExecutionException: java.lang.ExceptionInInitializerError
	at java.base/java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:396) ~[?:?] {}
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2073) ~[?:?] {}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.registry.StructurifyRegistryManagerProvider.reloadRegistryManager(StructurifyRegistryManagerProvider.java:62) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.config.data.WorldgenDataProvider.reload(WorldgenDataProvider.java:49) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.config.StructurifyConfig.load(StructurifyConfig.java:56) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:mixin,re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.Structurify.loadConfig(Structurify.java:80) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:mixin,re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.events.base.EventHandler.invoke(EventHandler.java:33) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.neoforge.StructurifyNeoForge.lambda$onIdkk$2(StructurifyNeoForge.java:55) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.DeferredWorkQueue.lambda$makeRunnable$2(DeferredWorkQueue.java:67) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.DeferredWorkQueue.makeRunnable(DeferredWorkQueue.java:62) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.DeferredWorkQueue.lambda$runTasks$0(DeferredWorkQueue.java:47) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at java.base/java.util.concurrent.ConcurrentLinkedDeque.forEach(ConcurrentLinkedDeque.java:1650) ~[?:?] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.DeferredWorkQueue.runTasks(DeferredWorkQueue.java:47) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimpleReloadInstance.lambda$new$3(SimpleReloadInstance.java:69) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:148) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,re:computing_frames,re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:111) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:accesstransformer:B,re:computing_frames,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.runTick(Minecraft.java:1155) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:configuration.mixins.json:MinecraftMixin from mod configuration,pl:mixin:APP:globalpacks.mixins.json:MinecraftMixin from mod globalpacks,pl:mixin:APP:yacl.mixins.json:MinecraftMixin from mod yet_another_config_lib_v3,pl:mixin:A,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.run(Minecraft.java:807) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:configuration.mixins.json:MinecraftMixin from mod configuration,pl:mixin:APP:globalpacks.mixins.json:MinecraftMixin from mod globalpacks,pl:mixin:APP:yacl.mixins.json:MinecraftMixin from mod yet_another_config_lib_v3,pl:mixin:A,pl:runtimedistcleaner:A}
	at TRANSFORMER/[email protected]/net.minecraft.client.main.Main.main(Main.java:230) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?] {}
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:136) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:124) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonClientLaunchHandler.runService(CommonClientLaunchHandler.java:32) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.lambda$launchService$4(CommonLaunchHandler.java:118) ~[loader-4.0.23.jar%23163!/:4.0] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:103) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:74) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-11.0.4.jar%23149!/:?] {}
	at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-11.0.4.jar%23149!/:?] {}
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:210) [bootstraplauncher-2.0.2.jar:?] {}
	at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69) [bootstraplauncher-2.0.2.jar:?] {}
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?] {}
	at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?] {}
	at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:67) [ForgeWrapper-prism-2024-02-29.jar:prism-2024-02-29] {}
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100) [NewLaunch.jar:?] {}
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) [NewLaunch.jar:?] {}
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) [NewLaunch.jar:?] {}
Caused by: java.lang.ExceptionInInitializerError
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.loader.GTOreLoader.apply(GTOreLoader.java:53) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.loader.GTOreLoader.apply(GTOreLoader.java:33) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimplePreparableReloadListener.lambda$reload$1(SimplePreparableReloadListener.java:19) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?] {}
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?] {}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimpleReloadInstance.lambda$new$3(SimpleReloadInstance.java:69) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.Util.blockUntilDone(Util.java:872) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at TRANSFORMER/[email protected]/net.minecraft.Util.blockUntilDone(Util.java:861) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.registry.StructurifyRegistryManagerProvider.reloadRegistryManager(StructurifyRegistryManagerProvider.java:48) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	... 41 more
Caused by: java.lang.IllegalStateException: [register] registry gtceu:ore_vein has been frozen
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.api.registry.GTRegistry.registerOrOverride(GTRegistry.java:117) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.api.worldgen.GTOreDefinition.register(GTOreDefinition.java:147) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.worldgen.GTOres.create(GTOres.java:744) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.worldgen.GTOres.create(GTOres.java:737) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.worldgen.GTOres.<clinit>(GTOres.java:63) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.loader.GTOreLoader.apply(GTOreLoader.java:53) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/com.gregtechceu.gtceu.data.loader.GTOreLoader.apply(GTOreLoader.java:33) ~[gtceu-1.21.1-1.4.0.jar%23190!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimplePreparableReloadListener.lambda$reload$1(SimplePreparableReloadListener.java:19) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:718) ~[?:?] {}
	at java.base/java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?] {}
	at TRANSFORMER/[email protected]/net.minecraft.server.packs.resources.SimpleReloadInstance.lambda$new$3(SimpleReloadInstance.java:69) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading}
	at TRANSFORMER/[email protected]/net.minecraft.Util.blockUntilDone(Util.java:872) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at TRANSFORMER/[email protected]/net.minecraft.Util.blockUntilDone(Util.java:861) ~[client-1.21-20240613.152323-srg.jar%23182!/:?] {re:classloading,re:mixin}
	at TRANSFORMER/[email protected]/com.faboslav.structurify.common.registry.StructurifyRegistryManagerProvider.reloadRegistryManager(StructurifyRegistryManagerProvider.java:48) ~[structurify-neoforge-mc1.21.1-1.0.5.jar%23197!/:?] {re:classloading}
	... 41 more

But since WorldStem.registries returns LayeredRegistryAccess<RegistryLayer> registries, which are already immutable by default, i dont understand why it tries to register new entries

Lines in this part of the log are matched correctly

Faboslav · Answer 17 · 2024-09-01T20:17:30.000Z

Based on my tests, i probably need to find a custom place to load my config, without use of the official events.

screret · Answer 18 · 2024-09-01T20:21:55.000Z

Lines in this part of the log are matched correctly

I couldn't find where you call new SimpleReloadInstance(...)

Faboslav · Answer 19 · 2024-09-01T20:28:58.000Z

I dont call that, everything related to the load is here: https://github.com/Faboslav/structurify/blob/master/common/src/main/java/com/faboslav/structurify/common/registry/StructurifyRegistryManagerProvider.java

reloadRegistryManager

Faboslav · Answer 20 · 2024-09-02T07:27:49.000Z

I found a solution with splitting my logic into several different places, thus closing this, thank you for your time!

Share to