GregTechCEu Modern

GregTechCEu Modern

6M Downloads

Large performance loss from 1.4.1 -> 1.4.2

Fuyukai opened this issue ยท 8 comments

commented

Checked for existing issues

  • I have checked for existing issues, and have found none.

Tested latest version

  • I have checked that this occurs on the latest version.

GregTech CEu Version

1.4.2

Minecraft Version

1.20.1

Recipe Viewer Installed

EMI

Environment

ssp

Cross-Mod Interaction

No

Other Installed Mods

too many to list here + largely not relevant. check the spark profiles list

Expected Behavior

  • Not to lose 5ms per tick

Actual Behavior

  • Lost 5ms per tick

Steps to Reproduce

  1. load the game
  2. press F3
  3. notice that integrated server tick time is way higher

Additional Information

Slow (1.4.2) spark profile: https://files.catbox.moe/sp40na.sparkprofile

Fast-ish (1.4.1) spark profile: https://files.catbox.moe/81sb8o.sparkprofile

The slower profile now spends significantly more time in RecipeLogic#findAndHandle.

commented

Hi, please reattach the profile for 1.4.2, I can't get it to load. Thanks.

commented

Hi, could you try with the gtceu-1.20.1-1.4.3.jar file found in this zip and let us know? Thanks. It looks like a problem that may have already been fixed in a PR but it hasn't made its way to release yet.

https://github.com/GregTechCEu/GregTech-Modern/actions/runs/11016580412/artifacts/1972244733

commented

Here's a second 1.4.2 profile: https://files.catbox.moe/s7ss07.sparkprofile

commented

could you run one with a --only-ticks-over 50 in the command parameters?

commented

so we actually see what's the laggy part

commented

Web viewer works this time: https://spark.lucko.me/1ogovtM3kR. Seems to be generators.

commented

This doesn't fix anything, sadly. Regular profile and 50ms profile still show the same slowdown.

commented

Git bisect shows that the commit that introduced the regression was 05f5dd1, or PR #1955.