Advanced Fluid Detector Cover (and Item) does not provide RS-Latch capabilities
teh-banana opened this issue ยท 0 comments
Checked for existing issues
- I have checked for existing issues, and have found none.
Tested latest version
- I have checked that this occurs on the latest version.
GregTech CEu Version
v1.4.6
Minecraft Version
1.20.1
Recipe Viewer Installed
EMI
Environment
Singleplayer
Cross-Mod Interaction
No
Other Installed Mods
EMI
Expected Behavior
The cover should stop/start emitting redstone based on the amounts specified in the GUI
Actual Behavior
The cover provides a dynamic redstone signal with the min/max being based on the values in the GUI
Steps to Reproduce
- Place Advanced Fluid Detector Cover on Input Bus
- Set the Minimum / Maximum values
- Place Redstone Dust next to cover
- Test different fluid levels, going above the max, below the minimum, and in between to try RS-Latch capabilities
Additional Information
The tool tip states that these covers provide RS-Latch controlled status. So either the tool tip is wrong, or the functionality is wrong.
The code does not use the latched redstone values like the Advanced Energy Detector cover.
Advanced Fluid Detector
Advanced Item Detector
Advanced Energy Detector
During some testing with trying to make this work in a dev environment, switching to the Latched method does work but changes the functionality. When modified, the signal inversion is opposite to what is described in the tooltip for the Advanced Fluid Detector, and the redstone output is no longer variable, but a 0 or 15.
If the RS-Latch capability is not intended, I also discovered that at larger values the dynamic value does not work as intended. I had a cover trying to reach 144,000 mB, and at around 141,000 mB it had a redstone signal of 1 but going to 142,000 mB it had a signal of 0.