Acidic fluids don't function
Kasyu opened this issue ยท 4 comments
Checked for existing issues
- I have checked for existing issues, and have found none.
Tested latest version
- I have checked that this occurs on the latest version.
GregTech CEu Version
v1.5.3
Minecraft Version
1.20.1
Recipe Viewer Installed
EMI
Environment
singleplayer
Cross-Mod Interaction
Unsure
Other Installed Mods
Pack is gregtech community pack modern
Expected Behavior
The questbook lists hydrochloric acid and sulfuric acid as having an acidic hazard, and should function as stated there, with a marker indicating being acidic, and pipes not listed as carrying acids burning and voiding fluid
Actual Behavior
no fluids use the acidic tag, including sulfuric and hydrochloric acid, and can be transported by regular pipes just fine
Steps to Reproduce
open gregtech community pack modern
place drum of sulfuric acid on pipe not listed as handling acids
allow draining from drum
nothing ends up happening with acidity
Additional Information
No response
Fixed in #2560
Bump. This has been a thing for a while now, too! Pipe overheating does seem to work (wooden pipes can't hold steam), so this is definitely specific for acids.
I can confirm this is still an issue in 1.5.5 as of 46e27f6.
It looks like the issue is down to how fluid properties are handled - fluids have a collection of FluidAttributes, and acids should have the FluidAttributes.ACID attribute. However, it seems like when fluids are registered, only the "flowing" variant of the fluid gets the attributes, and the FluidPipeBlockEntity checks if the "source" fluid has the attribute (which it does not.)
I spent a while trying to dig through the registry callback logic to see if I could fix this, but got a bit lost. Manually adding the ACID attribute to the source fluid did dissolve my pipes though.
