Checked for existing issues

• I have checked for existing issues, and have found none.

Tested latest version

• I have checked that this occurs on the latest version.

GregTech CEu Version

1.1.3.b

Recipe Viewer Installed

EMI

Environment

Singleplayer (Community Pack)

Cross-Mod Interaction

No

Other Installed Mods

GTCEu Community Pack 1.7.0

Expected Behavior

Pyrolyse oven overclocks work as tooltips explain:

• 75% processing speed at cupronickel
• 100% processing speed at kanthal
• 150% processing speed at nichrome

Actual Behavior

Processing speed is the same for all coil tiers I have tried (cupronickel/kanthal/nichrome), it seems like overclocks aren't working at all. Recipe time is what it should be at kanthal.

Recipe in screenshot is spruce logs -> wood tar on circuit 10. Note that it is 14s instead of 16s because of the configurable maintenance hatch discount (90%), running at MV on nichrome coils.

Same behavior with other recipes I've tried, eg logs on circuit 9 takes 29s with my 90% discount.

Steps to Reproduce

Build a pyrolyse oven with cupronickel coils. Run any recipe, confirm 75% penalty does not apply. Upgrade to nichrome, confirm 150% bonus does not aplpy.

Additional Information

Not sure if relevant but I also noticed that changing the duration modifier on the maintenance hatch does not take effect unless I break and replace the multiblock controller. This doesn't seem to help with the coil overclock though.

I did some investigation into this, and I think I have a better description of the issue: pyrolyse coil bonuses (or penalty for cupronickel) don't apply at all to recipes of the same tier that the machine itself is at. So if the recipe is an MV recipe and the oven is running at MV, coil bonuses do not apply. If I upgrade the pyro to HV, or try an LV recipe in the MV pyro, the bonuses apply as expected. (Note: cupronickel coils actually run at 80% processing speed, while the tooltip says 75% -- not sure which is correct, but should probably also be fixed.)

I tested with this recipe at the first 4 coil tiers (cupro, kanthal, nichrome, RTM):

At MV this recipe takes 32s in all of the ovens. At HV, it takes 20s, 16s, 11s, 8s, which lines up with expected bonuses.

I believe the issue is with this logic: https://github.com/GregTechCEu/GregTech-Modern/blob/5f9f2d8/src/main/java/com/gregtechceu/gtceu/api/recipe/RecipeHelper.java#L97 -- if the numberOfOCs it calculates is zero, it never even runs the pyrolyseOvenOverclock logic.

If I comment that line out, the bonuses start working, so maybe the fix is just to remove that line. I could see there being consequences of removing that though so would appreciate a second opinion from someone more familiar with the project.