Growthcraft Community Edition

Growthcraft Community Edition

1M Downloads

Lags in 4.1.0 Version

Opened this issue ยท 20 comments

commented

I experienced strong lags when being near to bibliocraft blocks. It was not the case for 4.0.3.100 . When taking a look at the performance profiling Shift+F3 in minecraft the cathegory gameRenderer.level.terrain_setup.rebuildNear went up very high.

No growthcraft blocks were placed in the world, which is kind of strange ...

commented

Had a similar problem with GC beehives during worldgen, which caused the game to hang, and ultimately forced me to close it. I was using the Quark Realistic worldtype. I don't see why it would have any problems, as it's literally a wrapper for a vanilla preset.

commented

Okay, try the 4.1.1 release by DM'ing Alatyami on Discord. Should clear that problem up, at least with the beehives.

commented

Fixed in 4.1.1

commented

Figured it out. So, the waila integration example had needed the TileEntity to sync more between the client/server. replaced the three lines to a simple markDirtyAndUpdate and now it should be scheduled instead of forced. The FermentBarrel.update() only updates the device class and not the TileEntity for the given barrel.

I've already pushed the fix, will cut a snapshot release later today.

commented

Good to know.

commented

Still occurs. Only removing these lines helped. Sorry, but I have to reopen this one again :)

I wouldn't expect, that using a scheduled variant instead would help. On the client side it will trigger a mesh rebuilding anyways. We need then something, which synchronizes the TileEntities but doesn't trigger a mesh update. Maybe a custom network package could help here.

commented

Is still occuring on rendering at terrain_setup.rebuildNear

grafik

commented

Update: I identified, that this issue was introduced between 4.0.4.500 and 4.0.5.100.

commented

Finally found the buggy merge commit. It seems that the Waila integration causes it.
The commit 83f7db5 on 2019-05-24 18:07:13 seems to have introduced rendering issues.

Update: The diffs show, that TileEntityFermentBarrel.update() has been extended to update the chunk on each update tick. It is strongly suspected to be the root cause. Is there a reason, why it has been introduced?

commented

That's a good question. I'll check my notes.

commented

Got finally everything working. Waila update without lags. Can somebody do a test of branch bugfix/265-render-lag-fix-atempt-2 using singleplayer scenario and also a server/client scenario for all devices?

Also, we really need to revise the whole chain of block updates and server/client communication stuff some day. It is a hacky mess here.

commented

Fixing GrowthcraftTileBase.onDataPacket() seems to break the cheese block :(

commented

That sucks, I like my cheese blocks.

commented

Don't worry. Cheese is working again. It got broken temporarily, because it relies on one code line I changed.

commented

Thank you!

commented

So is it recommended to use 4.1.1 or 4.1.1.300 from CurseForge?

commented

Recommend waiting for 4.1.1.400 come out later today. We're going to release either 4.2.0 or 4.1.2 before the 25th. Of note the x.x.x are the stable releases and the x.x.x.x are the snapshot releases.

commented

I see. I planned to release a modpack update today, so if you say so I will wait for 4.1.1.400 instead of updating only to 4.1.1.

commented

That did the trick. Major improvement to performance.