Growthcraft Community Edition

Growthcraft Community Edition

1M Downloads

Cellar: Apples can't go in fruit press (Harvestcraft conflict?)

Syndaryl opened this issue ยท 12 comments

commented

I'm back!

I can put purple grapes in the fruit press, but I can't put a stack of apples in, nor a single apple.

I have Pam's HarvestCraft 1.12.2za installed, and this version modifies vanilla apples to change their hunger restore value. I think this might have caused a problem here. Perhaps the press should be changed to use listAllApple? (EDIT: she's using cropApple, not listAllApple)

On a related note, Pams grapes can't be pressed either; I expected them to produce purple grape juice.

commented

As a follow-up, we use foodApple as the oredictionary for the recipe, Pams Harvestcraft doesn't add pamapple to the dictionary.

commented

Pam's harvestcraft doesn't replace the object - tis a Minecraft apple
https://cdn.discordapp.com/attachments/351546615816912896/528998492451110912/unknown.png

commented

Not sure what's going on in the back end with pams and the pamApple, but certainly by the time we get to MC it looks like a minecraft:apple.
But I added pamApple to ore:foodApple via CraftTweaker and it still doesn't work.

commented

In the latest version, they should work. After updating the mod you need to delete first the subfolder for growthcraft in the config folder to refresh the recipes. Then you can use the press with the new recipes which are created on next launch of Minecraft.

commented

Aha, reset the configs and that did the trick, Ta!

commented

The replacement apple gets registered here
https://github.com/MatrexsVigil/harvestcraft/blob/beeca969eea263b2f8754e02015d712bb955df9f/src/main/java/com/pam/harvestcraft/item/ItemRegistry.java
I can't follow how the item replacement works, but it gets registered in the oredict as cropApple. If you register the standard apple as cropApple, you should then be able to use the oredict entry?

commented

I think the line you wanted is here:
https://github.com/MatrexsVigil/harvestcraft/blob/003a600c8310535369b5bced60a191568e7f970c/src/main/java/com/pam/harvestcraft/item/GeneralOreRegistry.java#L1411

Also I've did a quick search over the codebase (Growthcraft), I don't think the pressing recipe is actually present, for now, you can check the growthcraft/config/cellar/pressing.json in your minecraft directory and see if the recipe is actually present

commented

Aha! No recipe! Let me try adding it.

commented

Here is the search I did:
https://github.com/GrowthcraftCE/Growthcraft-1.12/search?q=pressesFrom&unscoped_q=pressesFrom

If you do manage to fix it, please don't close this issue, as it needs to be added to the code, preferably using the ore

commented

I haven't looked at the code, but it's like the fruit press recipes need to use the OreItemStack instead of the fixed stacks.

This assumes the HarvestCraft registered the apples to the ore dictionary (once gain, I could be wrong, I don't know what the codebase looks like outside of 1.8)

commented

I can't seem to find a cider or applejuice fluid. This might be why the recipe doesn't exist.

commented

Apple and honey boozes are not supported. We are working on them now.