[please] the gigaherzcommon.jar needs to be external

Question

[please] the gigaherzcommon.jar needs to be external

kreezxil opened this issue 6 years ago · 4 comments

kreezxil commented 6 years ago

I'm getting really tired of having to remember to remove your core library everytime I update my modpack.

kreezxil · Answer 1 · 2018-03-29T00:04:05.000Z

The twitchapp doesn't warn anymore which is the problem then.

…

On Wed, Mar 28, 2018 at 3:58 PM, David Quintana ***@***.***> wrote: I'm NOT making it external. That would defeat all that I'm trying to achieve by doing that. If it's so much of a problem (even though the people from curse said that their modpack creation tools in the twitch app should be warning you about this before you upload), I might consider going back to shading instead of embedding. That however means that each mod jar will contain a duplicate of the code, which is not ideal. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADs0iOAEApEcaV6rHS1uKjQnMcvZQ5OHks5ti_mJgaJpZM4S_UhS> .

gigaherz · Answer 2 · 2018-03-28T20:58:49.000Z

I'm NOT making it external. That would defeat all that I'm trying to achieve by doing that. If it's so much of a problem (even though the people from curse said that their modpack creation tools in the twitch app should be warning you about this before you upload), I might consider going back to shading instead of embedding. That however means that each loaded mod will keep a duplicate of the code in memory, which is not ideal.

GrucciNishikino · Answer 3 · 2018-06-03T18:41:03.000Z

Perhaps that bug should be reported to the twitchapp team, if that's the case.

kreezxil · Answer 4 · 2018-06-04T12:44:57.000Z

turns out the FORGE team applied some kind of patch that takes all extra files such as yours and places them in a folder called "memory repo". Now it is simply a matter unchecking that before exporting.

…

On Sun, Jun 3, 2018 at 1:41 PM, PiggyClone205 ***@***.***> wrote: Perhaps that bug should be reported to the twitchapp team, if that's the case. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADs0iOXoJcMo1n6PuvT-pHc7oxGRQjIzks5t5C3AgaJpZM4S_UhS> .

Share to