Guidebook

Guidebook

Mods
6M Downloads

[Bug] Crash when opening book with empty chapters/sections

ElectroBot opened this issue · 3 comments

commented

The book below (with and without the empty sections) crashes the game. I was trying to find out how to have empty pages (realized later the sections are the pages).

<book title="Test book" cover="gbook:topsecret" fontSize="0.6" home="1:2"> <chapter> <section> </section> </chapter> </book>

Minecraft: 1.12.2
Forge: 14.23.5.2772
Guidebook: 1.12.2-2.8.3

Crash report: https://paste.dimdev.org/apusogiwor.rb

commented

Yes this is an issue with empty chapters.

Guidebook/src/main/java/gigaherz/guidebook/guidebook/client/BookRendering.java

Line 475 in cea8c04

final VisualPage pgLeft = ch.pages.get(currentPair * 2);

The line above throws an IndexOutOfBoundsException.
A possible way to fix this would be applying the same checks that are applied to the right-hand page for the left-hand page as well. Alternatively empty chapters could be removed and maybe a book without a chapter would not be able to open or automatically appear blank.

commented

There are uses for empty pages though (aesthetic). Not sure if applying the checks or maybe adding a tag for an blank page would doable.

commented
  • 👍1