Mana and artifice conflict with hammer lib
Dan1ss1mo opened this issue · 13 comments
https://www.curseforge.com/minecraft/mc-mods/mana-and-artifice
then both hammer lib and mana and artifice are present, opening MnA cantrip gui crash the game
to reproduce:
- read arcane codex to get mana pool
- get any of manaweaving wand
- press ctrl right click
- crash
https://pastebin.com/n01bAfRJ
Tested multiple version for 1.20.1, seems to be the case for all of them
I am having the same issue. Spoke with Mithion (Author of Mana and Artifice). He claims that it is an issue within Hammerlib.
Yeah sure, but what is their explanation besides just blaming another mod?
Like what was their research process, what did they find out and how it could be fixed?
This crash still doesn't have any HammerLib in the stack except MinecraftMixin, which doesn't do anything invasive whatsoever.
Again, I don't have their source code, so I can not really see what's going on either.
How... exactly is it HammerLib's fault...?
Doesn't seem like their source code is public, so I can't really judge, but I see not a single line in stack trace that could point to HammerLib causing the crash.
I can see some mixins in the stack trace, but none of them are of HammerLib.
The crash only happens when HammerLib is installed. Remove it and no crash.
crash-2024-03-23_17.01.09-client.txt
I might have uploaded the wrong crash log, so I did a pastebin.
As mentioned in the Discord, This is the message Mithion sent:
Mithion — Today at 6:39 PM
It's happening trying to look up recipes. If they're doing something to recipe searching in the name of optimization, then they'll break it.
I do not think there's anything related to recipe searching going on there. They are literally missing if(patterns != null) check
This is the only thing that is related to recipes - RecipeManagerMixin
It does not really interfere or change the expected vanilla behavior.
