Handcrafted

Handcrafted

40M Downloads

[Bug]: Top texture for wooden tables have upside down UV.

gclooa opened this issue ยท 1 comments

commented

Bug Description

Misaligned textures.
image

How to Reproduce?

Place down any wooden tables next to any other block using vanilla wooden plank textures.

Expected Behavior

UV should be inverted.

Version

3.0.6

Mod Loader Version

1.20.1

Mod Loader

Fabric

Logs or additional context

No response

Code of Conduct

  • I have searched the issue tracker and confirmed that the issue has not been reported
  • I have checked the FAQ (if one is present) and my issue is not listed
  • I have verified that I am using the latest version of the mod
  • I have verified that I have installed all the required dependencies for the mod
  • I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.
commented

I've made a PR that partially addresses this bug. It fixes the table, which doesn't have a facing property:

image

The trouble with the other blocks that do have a facing property is that the UVs need to be different for every direction. This can be achieved with blockstates, but blockstates can get too complex very fast with multiple properties (The table is 1636 lines of JSON because it has 3 different properties, with shape being the biggest).

Desks and Nightstands already have the facing property in their blockstates to denote model rotation, so the fix would simply involve adding 3 more models per block and referencing those models in the blockstate for each different facing direction.

If @terrariumearth thinks this is a good idea, I will go ahead and make another PR with those fixes, so please let me know (and tag me in the comment) Thank you!